Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: tests/standalone/io/uri_platform_test.dart

Issue 2439053005: Fix bug in test expectation for uri_platform test. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/standalone/standalone.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/uri_platform_test.dart
diff --git a/tests/standalone/io/uri_platform_test.dart b/tests/standalone/io/uri_platform_test.dart
index cc677606eababae1fe6a2fca603a4b04a7f00ad3..a42f2de8288238835aab4b82bd62df4cd05014b3 100644
--- a/tests/standalone/io/uri_platform_test.dart
+++ b/tests/standalone/io/uri_platform_test.dart
@@ -36,7 +36,11 @@ main() {
Expect.equals("a/b", new Uri.file("a/b").toFilePath());
Expect.equals("a\\b", new Uri.file("a\\b").toFilePath());
}
-
- Expect.equals(Uri.base,
- new Uri.file(Directory.current.path + Platform.pathSeparator));
+ // If the current path is only / (or \), then don't add a separator
+ // at the end.
+ Expect.equals(
+ Uri.base,
+ (Directory.current.path.toString() != Platform.pathSeparator)
zra 2016/10/22 05:21:07 This should probably compare against path.rootPref
Florian Schneider 2016/11/07 15:32:19 Done.
+ ? new Uri.file(Directory.current.path + Platform.pathSeparator)
+ : new Uri.file(Directory.current.path));
}
« no previous file with comments | « no previous file | tests/standalone/standalone.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698