Fix bug in test expectation for uri_platform test.

Fix bug in test expectation for uri_platform test.

This fixes this test when run from the root directory (/) like we
do when running precompiled tests on Android.

BUG=#26376
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/153b24ad59ad3c24913c443d4f80ceeca13a2d5e

[Florian Schneider, 2016-10-21 23:58:07]

fschneider@google.com changed reviewers:
+ zra@google.com

[zra, 2016-10-22 05:21:07]

https://codereview.chromium.org/2439053005/diff/1/tests/standalone/io/uri_pla...
File tests/standalone/io/uri_platform_test.dart (right):

https://codereview.chromium.org/2439053005/diff/1/tests/standalone/io/uri_pla...
tests/standalone/io/uri_platform_test.dart:43:
(Directory.current.path.toString() != Platform.pathSeparator)
This should probably compare against path.rootPrefix of the current path
instead. See:

https://www.dartdocs.org/documentation/path/1.4.0/path/rootPrefix.html

[Florian Schneider, 2016-11-07 15:32:19]

https://codereview.chromium.org/2439053005/diff/1/tests/standalone/io/uri_pla...
File tests/standalone/io/uri_platform_test.dart (right):

https://codereview.chromium.org/2439053005/diff/1/tests/standalone/io/uri_pla...
tests/standalone/io/uri_platform_test.dart:43:
(Directory.current.path.toString() != Platform.pathSeparator)
On 2016/10/22 05:21:07, zra wrote:
> This should probably compare against path.rootPrefix of the current path
> instead. See:
> 
> https://www.dartdocs.org/documentation/path/1.4.0/path/rootPrefix.html

Done.

[zra, 2016-11-07 15:53:05]

lgtm w/ nit

https://codereview.chromium.org/2439053005/diff/20001/tests/standalone/io/uri...
File tests/standalone/io/uri_platform_test.dart (right):

https://codereview.chromium.org/2439053005/diff/20001/tests/standalone/io/uri...
tests/standalone/io/uri_platform_test.dart:6: import 'package:path/path.dart';
as path

https://codereview.chromium.org/2439053005/diff/20001/tests/standalone/io/uri...
tests/standalone/io/uri_platform_test.dart:45:
rootPrefix(Directory.current.path.toString()))
path.rootPrefix

[Florian Schneider, 2016-11-07 15:58:26]

https://codereview.chromium.org/2439053005/diff/20001/tests/standalone/io/uri...
File tests/standalone/io/uri_platform_test.dart (right):

https://codereview.chromium.org/2439053005/diff/20001/tests/standalone/io/uri...
tests/standalone/io/uri_platform_test.dart:6: import 'package:path/path.dart';
On 2016/11/07 15:53:05, zra wrote:
> as path

Done. We don't seem to follow a system when using prefixed imports: expect.dart
is never imported with a prefix, neither is dart:io.

https://codereview.chromium.org/2439053005/diff/20001/tests/standalone/io/uri...
tests/standalone/io/uri_platform_test.dart:45:
rootPrefix(Directory.current.path.toString()))
On 2016/11/07 15:53:05, zra wrote:
> path.rootPrefix

Done.

[Florian Schneider, 2016-11-07 15:58:42]

Description was changed from

==========
Fix bug in test expectation for uri_platform test.

This fixes this test when run from the root directory (/) like we
do when running precompiled tests on Android.

BUG=#26376
==========

to

==========
Fix bug in test expectation for uri_platform test.

This fixes this test when run from the root directory (/) like we
do when running precompiled tests on Android.

BUG=#26376
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/153b24ad59ad3c24913c443d4f80ceeca13a2d5e
==========

[Florian Schneider, 2016-11-07 15:58:43]

Committed patchset #3 (id:40001) manually as
153b24ad59ad3c24913c443d4f80ceeca13a2d5e (presubmit successful).