Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 2439013002: Implement cross-origin attributes using access check interceptors. (Closed)
Patch Set: Revert to using the origin-safe method getters/setters to try to fix postMessage... Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
index 9a621418a09dae17d666c8bab8c8d23c7e6b5b0c..ad5ca71890b36167e71eb14e29d247bfaedb597c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
@@ -44,14 +44,6 @@ ScriptState::ScriptState(v8::Local<v8::Context> context,
ASSERT(m_world);
m_context.setWeak(this, &weakCallback);
context->SetAlignedPointerInEmbedderData(v8ContextPerContextDataIndex, this);
- v8::Local<v8::Object> global = context->Global();
- // TODO(jochen): Remove this once we correctly set internal fields on the
- // global proxy.
- if (global->InternalFieldCount()) {
- int indicies[] = {v8DOMWrapperTypeIndex, v8DOMWrapperObjectIndex};
- void* values[] = {nullptr, nullptr};
- global->SetAlignedPointerInInternalFields(2, indicies, values);
- }
}
ScriptState::~ScriptState() {

Powered by Google App Engine
This is Rietveld 408576698