Implement cross-origin attributes using access check interceptors.

third_party/WebKit/Source/bindings/IDLExtendedAttributes.md

Index: third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
diff --git a/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md b/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
index 6093d86fa9aa72e2474a81c620366ea64521da2b..4349142f8a964054a8fe0c7dcb5dada470b506d0 100644
--- a/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
+++ b/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
@@ -1402,44 +1402,91 @@ ScriptValue Object::attribute(ScriptExecutionContext* context)
 
 ### [CheckSecurity] _(i, m, a)_
 
-### [DoNotCheckSecurity] _(m, a)_
-
-Summary: Check whether a given access is allowed or not, in terms of the same-origin security policy. Used in Location.idl, Window.idl, and a few HTML*Element.idl.
-
-If the security check is necessary, you should specify `[CheckSecurity]`.
+Summary: Check whether a given access is allowed or not in terms of the
+same-origin security policy.
 
 *** note
-This is very important for security.
+It is very important to use this attribute for interfaces and properties that
+are exposed cross-origin!
 ***
 
-Usage: `[CheckSecurity=Frame]` can be specified on interfaces, which enables a _frame_ security check for all members (methods and attributes) of the interface. This can then be selectively disabled with `[DoNotCheckSecurity]`; this is only done in Location.idl and Window.idl. On attributes, `[DoNotCheckSecurity]` takes an optional identifier, as `[DoNotCheckSecurity=Setter]` (used only one place, Location.href, since setting `href` _changes_ the page, which is ok, but reading `href` leaks information).
-
-* `[DoNotCheckSecurity]` on a method disables the security check for the method.
-* `[DoNotCheckSecurity]` on an attribute disables the security check for a getter and setter of the attribute; for read only attributes this is just the getter.
-* `[DoNotCheckSecurity=Setter]` on an attribute disables the security check for a setter of the attribute, but not the getter.
+Usage for interfaces: `[CheckSecurity=Receiver]` enables a security check for
+all methods of an interface. The security check verifies that the caller still

[dcheng, 2016/11/02 09:07:41]

I need to figure out what's going on here tomorrow. I noticed that this security
check doesn't seem to be emitted for any getter or setter, and I'm not sure why.

For example, Window.history's generated bindings don't have this security check:

https://cs.chromium.org/chromium/src/out/Debug/gen/blink/bindings/core/v8/V8W...

But Window is CheckSecurity=Receiver and history is a normal access attribute...

[Yuki, 2016/11/02 09:43:49]

Based on the old (i.e. current) implementation, Window.history is not
cross-origin accessible, so it's not specified with kAllCanRead.  So, V8Window's
securityCheck() rejects the access to Window.history.

For cross-origin accessible attributes/operations (i.e. [DoNotCheckSecurity] ==
kAllCanRead), you can access to the property even if it's cross origin.  So
we're generating the call to BindingSecurity::shouldAllowAccessTo(receiver)
because of [CheckSecurity=Receiver].

This is what I remember.  Sorry if I remember wrong things.

+has access to the receiver object of the method when it is invoked. This is
+security-critical for interfaces that can be returned cross-origin, such as the
+Location or Window interface.
 
 ```webidl
 [
-    CheckSecurity=Frame,
+    CheckSecurity=Receiver,
 ] interface DOMWindow {
-    attribute DOMString str1;
-    [DoNotCheckSecurity] attribute DOMString str2;
-    [DoNotCheckSecurity=Setter] attribute DOMString str3;
-    void func1();
-    [DoNotCheckSecurity] void func2();
+    Selection? getSelection();
 };
 ```
 
-Consider the case where you access `window.parent` from inside an iframe that comes from a different origin. While it is allowed to access window.parent, it is not allowed to access `window.parent.document`. In such cases, you need to specify `[CheckSecurity]` in order to check whether a given DOM object is allowed to access the attribute or method, in terms of the same-origin security policy.
+Forgetting this attribute would make it possible to cache a method reference and
+invoke it on a cross-origin object:
 
-`[CheckSecurity=Node]` can be specified on methods and attributes, which enables a _node_ security check on that member. In practice all attribute uses are read only, and method uses all also have `[RaisesException]`:
+```js
+var iframe = document.body.appendChild(document.createElement('iframe'));
+var addEventListenerMethod = iframe.contentWindow.addEventListener;
+iframe.src = 'https://example.com';
+iframe.onload = function () {
+  addEventListenerMethod('pointermove', function (event) {
+    event.target.ownerDocument.body.innerText = 'Text from a different origin.';
+  });
+};

[dcheng, 2016/11/02 09:07:41]

I added some examples, because I didn't initially understand why this is
important.

+```
+
+Usage for attributes and methods: `[CheckSecurity=ReturnValue]` enables a
+security check on that property. The security check verifies that the caller is
+allowed to access the returned value. If access is denied, the return value will
+be `undefined` and an exception will be raised. In practice, attribute uses are
+all `[readonly]`, and method uses are all `[RaisesException]`.
 
 ```webidl
-[CheckSecurity=Node] readonly attribute Document contentDocument;
-[CheckSecurity=Node] SVGDocument getSVGDocument();
+[CheckSecurity=ReturnValue] readonly attribute Document contentDocument;
+[CheckSecurity=ReturnValue] SVGDocument getSVGDocument();
 ```
 
-In terms of the same-origin security policy, node.contentDocument should return undefined if the parent frame and the child frame are from different origins.
+This is important because cross-origin access is not transitive. For example, if
+`window` and `window.parent` are cross-origin, access to `window.parent` is
+allowed, but access to `window.parent.document` is not.
+
+### [CrossOrigin] _(m, a)_
+
+Summary: Allows cross-origin access to an attribute or method. Used for
+implementing [CrossOriginProperties] from the spec in Location.idl and
+Window.idl.
+
+Usage for methods:
+```webidl
+[CrossOrigin] void blur();
+```
+
+Note that setting this attribute on a method will disable [security
+checks](CheckSecurity), since this method can be invoked cross-origin.
+
+Usage for attributes:
+```webidl
+[CrossOrigin] readonly attribute unsigned long length;
+```
+With no arguments, defaults to allowing cross-origin reads, but
+not cross-origin writes.
+
+```webidl```
+[CrossOrigin=Setter] attribute DOMString href;
+```
+With `Setter`, allows cross-origin writes, but not cross-origin reads. This is
+used for the `Location.href` attribute: cross-origin writes to this attribute
+are allowed, since it navigates the browsing context, but allowing cross-origin
+reads would leak cross-origin information.
+
+```webidl```
+[CrossOrigin=(Getter,Setter)] readonly attribute Location location;
+```
+With both `Getter` and `Setter`, allows both cross-origin reads and cross-origin
+writes. This is used for the `Window.location` attribute.
 
 ### [CustomConstructor] _(i)_
 
@@ -1612,3 +1659,5 @@ Redistribution and use in source and binary forms, with or without modification,
 
 THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS “AS IS” AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 ***
+
+[CrossOriginProperties]: https://html.spec.whatwg.org/multipage/browsers.html#crossoriginproperties-(-o-)

[dcheng, 2016/11/02 09:07:41]

I think this is more readable than having all the links inline: hopefully the
markdown generator agrees (I'll check this when I'm in the office tomorrow)