third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceCheckSecurity.idl - Issue 2439013002: Implement cross-origin attributes using access check interceptors.

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceCheckSecurity.idl

Issue 2439013002: Implement cross-origin attributes using access check interceptors. (Closed)

Patch Set: . Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/idls/core/TestInterface.idl ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | third_party/WebKit/Source/core/frame/DOMWindow.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceCheckSecurity.idl

diff --git a/third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceCheckSecurity.idl b/third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceCheckSecurity.idl

index e53b649419987d8f11d5290d3bd32d120fa17918..d9df642f51452bb1fd24f9d4957e380e640c4915 100644

--- a/third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceCheckSecurity.idl

+++ b/third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceCheckSecurity.idl

@@ -34,12 +34,12 @@

attribute long longAttribute;

void voidMethod();

- [DoNotCheckSecurity] attribute long doNotCheckSecurityLongAttribute;

- [DoNotCheckSecurity] readonly attribute long doNotCheckSecurityReadonlyLongAttribute; // Separate read only attribute to check attribute configuration

- [DoNotCheckSecurity=Setter] attribute long doNotCheckSecurityOnSetterLongAttribute;

- [DoNotCheckSecurity, Replaceable] readonly attribute long doNotCheckSecurityReplaceableReadonlyLongAttribute;

+ [CrossOrigin] attribute long doNotCheckSecurityLongAttribute;

+ [CrossOrigin] readonly attribute long doNotCheckSecurityReadonlyLongAttribute; // Separate read only attribute to check attribute configuration

+ [CrossOrigin=Setter] attribute long doNotCheckSecurityOnSetterLongAttribute;

+ [CrossOrigin, Replaceable] readonly attribute long doNotCheckSecurityReplaceableReadonlyLongAttribute;

- [DoNotCheckSecurity] void doNotCheckSecurityVoidMethod();

- [DoNotCheckSecurity, PerWorldBindings] void doNotCheckSecurityPerWorldBindingsVoidMethod();

- [DoNotCheckSecurity, Unforgeable] void doNotCheckSecurityUnforgeableVoidMethod();

+ [CrossOrigin] void doNotCheckSecurityVoidMethod();

+ [CrossOrigin, PerWorldBindings] void doNotCheckSecurityPerWorldBindingsVoidMethod();

dcheng 2016/11/02 01:46:42 The IDL tests this case, but we never actually use

Yuki 2016/11/02 08:26:39 I'm happy with removing this entirely.

dcheng 2016/11/03 07:44:45 However, it's weird: the bindings generator isn't

Yuki 2016/11/07 05:02:41 Why do you think "it should be"? The bindings gen

+ [CrossOrigin, Unforgeable] void doNotCheckSecurityUnforgeableVoidMethod();

};