GN: move webrtc/video/ targets from webrtc/BUILD.gn into webrtc/video/BUILD.gn

webrtc/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # TODO(kjellander): Rebase this to webrtc/build/common.gypi changes after r6330.
 
@@ skipping 594 matching lines @@
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_native_code" ]
       shard_timeout = 900
     }
 
     if (is_ios) {
       deps += [ ":video_engine_tests_bundle_data" ]
     }
   }
 
-  rtc_source_set("video_quality_test") {
-    testonly = true
-    sources = [
-      "video/video_quality_test.cc",
-      "video/video_quality_test.h",
-    ]
-    deps = [
-      ":webrtc",
-      "system_wrappers",
-      "//testing/gtest",
-    ]
-    if (!is_android) {
-      deps += [ "modules/video_capture:video_capture_internal_impl" ]
-    }
-    if (!build_with_chromium && is_clang) {
-      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
-  }
-
   webrtc_perf_tests_resources = [
     "//resources/audio_coding/speech_mono_16kHz.pcm",
     "//resources/audio_coding/testfile32kHz.pcm",
     "//resources/ConferenceMotion_1280_720_50.yuv",
     "//resources/difficult_photo_1850_1110.yuv",
     "//resources/foreman_cif.yuv",
     "//resources/google-wifi-3mbps.rx",
     "//resources/paris_qcif.yuv",
     "//resources/photo_1850_1110.yuv",
     "//resources/presentation_1850_1110.yuv",
@@ skipping 14 matching lines @@
 
   rtc_executable("webrtc_tests") {
     testonly = true
     deps = [
       ":webrtc",
       "modules/video_capture:video_capture_internal_impl",
       "test",
     ]
   }
 
-  rtc_executable("video_loopback") {
-    testonly = true
-    sources = [
-      "test/run_test.h",
-      "video/video_loopback.cc",
-    ]
-
-    if (is_mac) {
-      sources += [ "test/mac/run_test.mm" ]
-    } else {
-      sources += [ "test/run_test.cc" ]
-    }
-    deps = [
-      ":video_quality_test",
-      "system_wrappers:metrics_default",
-      "test:field_trial",
-      "test:test_common",
-      "test:test_renderer",
-      "//testing/gmock",
-      "//testing/gtest",
-      "//third_party/gflags",
-    ]
-    if (!build_with_chromium && is_clang) {
-      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
-  }
-
-  rtc_executable("screenshare_loopback") {
-    testonly = true
-    sources = [
-      "test/run_test.h",
-      "video/screenshare_loopback.cc",
-    ]
-
-    if (is_mac) {
-      sources += [ "test/mac/run_test.mm" ]
-    } else {
-      sources += [ "test/run_test.cc" ]
-    }
-    deps = [
-      ":video_quality_test",
-      "system_wrappers:metrics_default",
-      "test:field_trial",
-      "test:test_common",
-      "test:test_renderer",
-      "//testing/gmock",
-      "//testing/gtest",
-      "//third_party/gflags",
-    ]
-    if (is_clang && !is_nacl) {
-      # Suppress warnings from Chrome's Clang plugins.
-      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
-  }
-
   rtc_test("webrtc_perf_tests") {
     testonly = true
     configs += [ ":rtc_unittests_config" ]
 
     sources = [
       "call/call_perf_tests.cc",
       "call/rampup_tests.cc",
       "call/rampup_tests.h",
       "modules/audio_coding/neteq/test/neteq_performance_unittest.cc",
       "modules/audio_processing/audio_processing_performance_unittest.cc",
       "modules/audio_processing/level_controller/level_controller_complexity_unittest.cc",
       "modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc",
       "video/full_stack.cc",
     ]
     deps = [
-      ":video_quality_test",
-      ":webrtc",

[kjellander_webrtc, 2016/10/21 07:16:09]

Turns out this is not needed, which is great.

[kjellander_webrtc, 2016/10/24 06:49:54]

I forgot to add the dependency on modules/video_capture:video_capture_module to
enable this though. Fixed in PS#2.

       "modules/audio_coding:neteq_test_support",
       "modules/audio_processing",
       "modules/audio_processing:audioproc_test_utils",
       "modules/remote_bitrate_estimator:bwe_simulator_lib",
       "modules/rtp_rtcp",
       "test:test_common",
       "test:test_main",
       "test:test_renderer",
+      "video:video_quality_test",
       "voice_engine",
       "//testing/gmock",
       "//testing/gtest",
     ]
 
     if (rtc_enable_intelligibility_enhancer) {
       defines = [ "WEBRTC_INTELLIGIBILITY_ENHANCER=1" ]
     } else {
       defines = [ "WEBRTC_INTELLIGIBILITY_ENHANCER=0" ]
     }
@@ skipping 52 matching lines @@
 
       deps = [
         "//base:base_java_test_support",
         "//webrtc/api:libjingle_peerconnection_java",
         "//webrtc/api:libjingle_peerconnection_jni",
         "//webrtc/examples:AppRTCMobile_javalib",
       ]
     }
   }
 }