Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: components/cronet/tools/generate_javadoc.py

Issue 2438913004: Revert of [Reland] Upgrade to new Android SDK. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/api/build.xml ('k') | docs/android_test_instructions.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/generate_javadoc.py
diff --git a/components/cronet/tools/generate_javadoc.py b/components/cronet/tools/generate_javadoc.py
index 7a4b98925861e94208a2e7817a0ebf48da1031be..3914b91ed235643cbecda7911d1e3ebce6bdf5d6 100755
--- a/components/cronet/tools/generate_javadoc.py
+++ b/components/cronet/tools/generate_javadoc.py
@@ -43,15 +43,9 @@
'-Dlib.java.dir=' + lib_java_dir, '-Doverview=' + overview_file,
'doc']
stdout = build_utils.CheckOutput(javadoc_cmd, cwd=working_dir)
- for line in stdout.splitlines():
- if " error: " in line or "javadoc: error " in line:
- build_utils.DeleteDirectory(output_dir)
- raise build_utils.CalledProcessError(working_dir, javadoc_cmd, stdout)
- # TODO(crbug.com/655666): remove compiler suppression warning once fixed.
- if ("warning" in line and not line.endswith('warnings') and
- not "the highest major version" in line):
- build_utils.DeleteDirectory(output_dir)
- raise build_utils.CalledProcessError(working_dir, javadoc_cmd, stdout)
+ if " error: " in stdout or "warning" in stdout or "javadoc: error " in stdout:
+ build_utils.DeleteDirectory(output_dir)
+ raise build_utils.CalledProcessError(working_dir, javadoc_cmd, stdout)
def main():
« no previous file with comments | « components/cronet/android/api/build.xml ('k') | docs/android_test_instructions.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698