Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: chrome/browser/media_galleries/fileapi/picasa_data_provider.cc

Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch(). (Closed)
Patch Set: CR thestig #36 (fix comment) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
diff --git a/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc b/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
index 04360a930e6ce2e763f76a9ece40c96cc29373ce..15275cc21e8b50c52d84ef79728c8021aee6ce7a 100644
--- a/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
+++ b/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
@@ -51,7 +51,9 @@ PicasaDataProvider::PicasaDataProvider(const base::FilePath& database_path)
weak_factory_.GetWeakPtr()));
}
-PicasaDataProvider::~PicasaDataProvider() {}
+PicasaDataProvider::~PicasaDataProvider() {
+ StopFilePathWatchOnMediaTaskRunner(std::move(temp_dir_watcher_));
+}
void PicasaDataProvider::RefreshData(DataType needed_data,
const ReadyCallback& ready_callback) {
« no previous file with comments | « chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc ('k') | chrome/common/service_process_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698