Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6702)

Unified Diff: chrome/browser/media_galleries/fileapi/iapps_data_provider.cc

Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch(). (Closed)
Patch Set: CR thestig #36 (fix comment) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
diff --git a/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc b/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
index ec8cfd26052ca1382fdf018aeb8bf42a86ed1656..72e90365ceeac4d58d07b4bdafd9f8e8c50685ba 100644
--- a/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
+++ b/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
@@ -40,7 +40,9 @@ IAppsDataProvider::IAppsDataProvider(const base::FilePath& library_path)
weak_factory_.GetWeakPtr()));
}
-IAppsDataProvider::~IAppsDataProvider() {}
+IAppsDataProvider::~IAppsDataProvider() {
+ StopFilePathWatchOnMediaTaskRunner(std::move(library_watcher_));
+}
bool IAppsDataProvider::valid() const {
return is_valid_;

Powered by Google App Engine
This is Rietveld 408576698