chrome/browser/media_galleries/fileapi/file_path_watcher_util.h - Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/file_path_watcher_util.h

Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch(). (Closed)

Patch Set: CR thestig #36 (fix comment) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media_galleries/fileapi/file_path_watcher_util.h

diff --git a/chrome/browser/media_galleries/fileapi/file_path_watcher_util.h b/chrome/browser/media_galleries/fileapi/file_path_watcher_util.h

index 8e512534c8c5d3300086b83daf0c3f71dfff44df..cd3443dd1dd4969f75e385e8ed229a95417185c3 100644

--- a/chrome/browser/media_galleries/fileapi/file_path_watcher_util.h

+++ b/chrome/browser/media_galleries/fileapi/file_path_watcher_util.h

@@ -22,4 +22,9 @@ void StartFilePathWatchOnMediaTaskRunner(

const FileWatchStartedCallback& watch_started_callback,

const base::FilePathWatcher::Callback& path_changed_callback);

+// Stops a file path watch started by StartFilePathWatchOnMediaTaskRunner().

+// Must be called from the MediaTaskRunner.

+void StopFilePathWatchOnMediaTaskRunner(

+ std::unique_ptr<base::FilePathWatcher> watcher);

#endif // CHROME_BROWSER_MEDIA_GALLERIES_FILEAPI_FILE_PATH_WATCHER_UTIL_H_