base/files/file_path_watcher_win.cc - Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_path_watcher_win.cc

Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch(). (Closed)

Patch Set: CR dcheng #33 (fix comment) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_path_watcher_win.cc

diff --git a/base/files/file_path_watcher_win.cc b/base/files/file_path_watcher_win.cc

index 3bbf2fba5037524fd05125535936da6061183420..48470b6b3dbb05381a6cde56d47bdcc53dbcc211 100644

--- a/base/files/file_path_watcher_win.cc

+++ b/base/files/file_path_watcher_win.cc

@@ -296,6 +296,7 @@ void FilePathWatcherImpl::DestroyWatch() {

} // namespace

FilePathWatcher::FilePathWatcher() {

+ sequence_checker_.DetachFromSequence();

impl_ = new FilePathWatcherImpl();

}