Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Side by Side Diff: chrome/browser/media_galleries/fileapi/file_path_watcher_util.cc

Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch(). (Closed)
Patch Set: CR thestig #36 (fix comment) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media_galleries/fileapi/file_path_watcher_util.h" 5 #include "chrome/browser/media_galleries/fileapi/file_path_watcher_util.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 const FileWatchStartedCallback& watch_started_callback, 51 const FileWatchStartedCallback& watch_started_callback,
52 const base::FilePathWatcher::Callback& path_changed_callback) { 52 const base::FilePathWatcher::Callback& path_changed_callback) {
53 MediaFileSystemBackend::AssertCurrentlyOnMediaSequence(); 53 MediaFileSystemBackend::AssertCurrentlyOnMediaSequence();
54 content::BrowserThread::PostTask(content::BrowserThread::FILE, 54 content::BrowserThread::PostTask(content::BrowserThread::FILE,
55 FROM_HERE, 55 FROM_HERE,
56 base::Bind(&StartFilePathWatchOnFileThread, 56 base::Bind(&StartFilePathWatchOnFileThread,
57 path, 57 path,
58 watch_started_callback, 58 watch_started_callback,
59 path_changed_callback)); 59 path_changed_callback));
60 } 60 }
61
62 void StopFilePathWatchOnMediaTaskRunner(
63 std::unique_ptr<base::FilePathWatcher> watcher) {
64 MediaFileSystemBackend::AssertCurrentlyOnMediaSequence();
65 if (watcher) {
66 const bool task_posted = content::BrowserThread::DeleteSoon(
67 content::BrowserThread::FILE, FROM_HERE, watcher.release());
68
69 // This will fail if the FILE thread has been stopped.
70 DCHECK(task_posted);
71 }
72 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698