base/files/file_path_watcher_win.cc - Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/files/file_path_watcher_win.cc

Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch(). (Closed)

Patch Set: CR thestig #36 (fix comment) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/files/file_path_watcher.h"	5 #include "base/files/file_path_watcher.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/files/file.h"	8 #include "base/files/file.h"

9 #include "base/files/file_path.h"	9 #include "base/files/file_path.h"

10 #include "base/files/file_util.h"	10 #include "base/files/file_util.h"

(...skipping 278 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
289	289

290 void FilePathWatcherImpl::DestroyWatch() {	290 void FilePathWatcherImpl::DestroyWatch() {

291 watcher_.StopWatching();	291 watcher_.StopWatching();

292 FindCloseChangeNotification(handle_);	292 FindCloseChangeNotification(handle_);

293 handle_ = INVALID_HANDLE_VALUE;	293 handle_ = INVALID_HANDLE_VALUE;

294 }	294 }

295	295

296 } // namespace	296 } // namespace

297	297

298 FilePathWatcher::FilePathWatcher() {	298 FilePathWatcher::FilePathWatcher() {

	299 sequence_checker_.DetachFromSequence();

299 impl_ = new FilePathWatcherImpl();	300 impl_ = new FilePathWatcherImpl();

300 }	301 }

301	302

302 } // namespace base	303 } // namespace base

OLD	NEW