base/files/file_path_watcher_stub.cc - Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/files/file_path_watcher_stub.cc

Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch(). (Closed)

Patch Set: CR thestig #36 (fix comment) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This file exists for Unix systems which don't have the inotify headers, and	5 // This file exists for Unix systems which don't have the inotify headers, and

6 // thus cannot build file_watcher_inotify.cc	6 // thus cannot build file_watcher_inotify.cc

7	7

8 #include "base/files/file_path_watcher.h"	8 #include "base/files/file_path_watcher.h"

9	9

10 namespace base {	10 namespace base {

(...skipping 10 matching lines...) Expand all Loading...
21	21

22 void Cancel() override {}	22 void Cancel() override {}

23	23

24 protected:	24 protected:

25 ~FilePathWatcherImpl() override {}	25 ~FilePathWatcherImpl() override {}

26 };	26 };

27	27

28 } // namespace	28 } // namespace

29	29

30 FilePathWatcher::FilePathWatcher() {	30 FilePathWatcher::FilePathWatcher() {

	31 sequence_checker_.DetachFromSequence();

31 impl_ = new FilePathWatcherImpl();	32 impl_ = new FilePathWatcherImpl();

32 }	33 }

33	34

34 } // namespace base	35 } // namespace base

OLD	NEW

« no previous file with comments | « base/files/file_path_watcher_mac.cc ('k') | base/files/file_path_watcher_unittest.cc » ('j') | no next file with comments »