base/files/file_path_watcher_mac.cc - Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/files/file_path_watcher_mac.cc

Issue 2438913003: Require FilePathWatcher destructor to be called in sequence with Watch(). (Closed)

Patch Set: CR dcheng #33 (fix comment) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/files/file_path_watcher.h"	5 #include "base/files/file_path_watcher.h"

6 #include "base/files/file_path_watcher_kqueue.h"	6 #include "base/files/file_path_watcher_kqueue.h"

7 #include "build/build_config.h"	7 #include "build/build_config.h"

8	8

9 #if !defined(OS_IOS)	9 #if !defined(OS_IOS)

10 #include "base/files/file_path_watcher_fsevents.h"	10 #include "base/files/file_path_watcher_fsevents.h"

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42	42

43 protected:	43 protected:

44 ~FilePathWatcherImpl() override {}	44 ~FilePathWatcherImpl() override {}

45	45

46 scoped_refptr<PlatformDelegate> impl_;	46 scoped_refptr<PlatformDelegate> impl_;

47 };	47 };

48	48

49 } // namespace	49 } // namespace

50	50

51 FilePathWatcher::FilePathWatcher() {	51 FilePathWatcher::FilePathWatcher() {

	52 sequence_checker_.DetachFromSequence();

52 impl_ = new FilePathWatcherImpl();	53 impl_ = new FilePathWatcherImpl();

53 }	54 }

54	55

55 } // namespace base	56 } // namespace base

OLD	NEW