Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2438903002: Fuchsia: Use mx_handle_wait_many in the eventhandler (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Use mx_handle_wait_many in the eventhandler This is to set up for more handles coming in from sockets, etc. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/2312ff7cf47632d6bf4fa9bfc813237697e03082

Patch Set 1 #

Patch Set 2 : Add logging #

Total comments: 4

Patch Set 3 : Add NULL checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -16 lines) Patch
M runtime/bin/eventhandler_fuchsia.h View 3 chunks +75 lines, -0 lines 0 comments Download
M runtime/bin/eventhandler_fuchsia.cc View 1 2 6 chunks +172 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 2 months ago (2016-10-21 16:28:25 UTC) #2
siva
lgtm https://codereview.chromium.org/2438903002/diff/20001/runtime/bin/eventhandler_fuchsia.cc File runtime/bin/eventhandler_fuchsia.cc (right): https://codereview.chromium.org/2438903002/diff/20001/runtime/bin/eventhandler_fuchsia.cc#newcode41 runtime/bin/eventhandler_fuchsia.cc:41: malloc(kInitialCapacity * sizeof(*signals_states_))); ASSERT/FATAL for NULL value returns ...
4 years, 2 months ago (2016-10-21 20:21:51 UTC) #3
zra
https://codereview.chromium.org/2438903002/diff/20001/runtime/bin/eventhandler_fuchsia.cc File runtime/bin/eventhandler_fuchsia.cc (right): https://codereview.chromium.org/2438903002/diff/20001/runtime/bin/eventhandler_fuchsia.cc#newcode41 runtime/bin/eventhandler_fuchsia.cc:41: malloc(kInitialCapacity * sizeof(*signals_states_))); On 2016/10/21 20:21:50, siva wrote: > ...
4 years, 2 months ago (2016-10-21 20:37:41 UTC) #4
zra
4 years, 2 months ago (2016-10-21 20:38:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2312ff7cf47632d6bf4fa9bfc813237697e03082.

Powered by Google App Engine
This is Rietveld 408576698