Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2438893002: HalfFloat avx2 unpack bug fix. (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
Reviewers:
wangcheng
CC:
hubbe
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

HalfFloat avx2 unpack bug fix. AVX unpack parameters were reverse ordered causing incorrect results on AVX2 hardware. TEST=/usr/local/google/home/fbarchard/intelsde/sde -skx -- out/Release/libyuv_unittest --gtest_filter=*Half* BUG=libyuv:560 R=wangcheng@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/550cf829fb130dc567e27717252e3510cd63b306

Patch Set 1 #

Patch Set 2 : avx2 unpack bug fix #

Patch Set 3 : bump version to 1629 #

Patch Set 4 : reinterpret_cast for lint #

Patch Set 5 : test use random #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M README.chromium View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M source/row_gcc.cc View 2 chunks +6 lines, -6 lines 1 comment Download
M unit_test/planar_test.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
wangcheng
https://codereview.chromium.org/2438893002/diff/80001/source/row_gcc.cc File source/row_gcc.cc (right): https://codereview.chromium.org/2438893002/diff/80001/source/row_gcc.cc#newcode5355 source/row_gcc.cc:5355: "vpunpckhwd %%ymm5,%%ymm2,%%ymm3 \n" // mutates reverse order of ymm5 ...
4 years, 2 months ago (2016-10-20 22:38:30 UTC) #3
wangcheng
https://codereview.chromium.org/2438893002/diff/80001/source/row_gcc.cc File source/row_gcc.cc (right): https://codereview.chromium.org/2438893002/diff/80001/source/row_gcc.cc#newcode5355 source/row_gcc.cc:5355: "vpunpckhwd %%ymm5,%%ymm2,%%ymm3 \n" // mutates reverse order of ymm5 ...
4 years, 2 months ago (2016-10-20 22:38:30 UTC) #4
wangcheng
4 years, 2 months ago (2016-10-20 22:38:31 UTC) #5
wangcheng
lgtm
4 years, 2 months ago (2016-10-20 22:39:18 UTC) #6
fbarchard1
4 years, 2 months ago (2016-10-20 22:49:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
550cf829fb130dc567e27717252e3510cd63b306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698