Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: runtime/bin/run_vm_tests_fuchsia.cc

Issue 2438843002: Fuchsia: Add native symbol resolver. Small fixes. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/log_fuchsia.cc ('k') | runtime/platform/utils_fuchsia.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/run_vm_tests_fuchsia.cc
diff --git a/runtime/bin/run_vm_tests_fuchsia.cc b/runtime/bin/run_vm_tests_fuchsia.cc
index a974860eaae56e676cc0cb0c10fee1ec5664539d..db8baf2675bfaa03b209d299b8a836908c3b50d6 100644
--- a/runtime/bin/run_vm_tests_fuchsia.cc
+++ b/runtime/bin/run_vm_tests_fuchsia.cc
@@ -98,17 +98,12 @@ const char* kExpectFail[] = {
"Fail2",
"AllocGeneric_Overflow",
"CodeImmutability",
+ // Assumes initial thread's stack is the same size as spawned thread stacks.
+ "StackOverflowStacktraceInfo",
};
// Bugs to fix, or things that are not yet implemented.
const char* kBugs[] = {
- // Needs NativeSymbolResolver
- "Service_PersistentHandles",
- // Needs lstat
- "DirectoryCreateTemp",
- "DirectoryCreateDelete",
- // Needs rename
- "DirectoryRename",
// Needs read of RSS.
"InitialRSS",
};
@@ -346,7 +341,7 @@ static void* test_runner_thread(void* arg) {
static void run_all_tests(runner_args_t* args) {
const intptr_t num_cpus = sysconf(_SC_NPROCESSORS_CONF);
pthread_t* threads =
- reinterpret_cast<pthread_t*>(malloc(num_cpus * sizeof(pthread_t)));
+ reinterpret_cast<pthread_t*>(malloc(num_cpus * sizeof(pthread_t)));
for (int i = 0; i < num_cpus; i++) {
pthread_create(&threads[i], NULL, test_runner_thread, args);
}
« no previous file with comments | « runtime/bin/log_fuchsia.cc ('k') | runtime/platform/utils_fuchsia.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698