Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2438803002: Dereference and std::move in same param list == top crasher (Closed)

Created:
4 years, 2 months ago by Roger Tawa OOO till Jul 10th
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit), ajha
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2896
Project:
chromium
Visibility:
Public.

Description

Dereference and std::move in same param list == top crasher Fix a top crasher (2016/10/20) caused by defer of a unique_ptr and a std::move of the same unique_ptr in the same parameter list. The order of evalulation is unspecified, so this is unsafe. BUG=657778 R=ajha@chromium.org, avi@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2437123002 Cr-Commit-Position: refs/heads/master@{#426553} (cherry picked from commit 884c98b01d2daebaa2f519300d3f64b2850f31fe) Committed: https://chromium.googlesource.com/chromium/src/+/99267e28b9e6977de841fef3d3ee62f8d028718a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Roger Tawa OOO till Jul 10th
Committed patchset #1 (id:1) manually as 99267e28b9e6977de841fef3d3ee62f8d028718a.
4 years, 2 months ago (2016-10-20 19:40:37 UTC) #2
Avi (use Gerrit)
4 years, 2 months ago (2016-10-20 19:41:38 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698