Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(143)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: content/test/data/navigation_controller/inject_subframe_into_blank_iframe.html
Issue
2438743005
:
Fix history nav to a script-injected about:blank frame. (Closed)
Patch Set: Fix nits.
Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
content/browser/frame_host/navigation_controller_impl_browsertest.cc
content/browser/frame_host/navigation_entry_impl.h
content/browser/frame_host/navigation_entry_impl.cc
content/browser/frame_host/navigation_request.cc
content/common/navigation_params.h
content/common/navigation_params.cc
content/renderer/render_frame_impl.h
content/renderer/render_frame_impl.cc
content/test/data/navigation_controller/inject_iframe_srcdoc_with_nested_frame.html
content/test/data/navigation_controller/inject_subframe_into_blank_iframe.html
testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter
View unified diff
|
Download patch
« content/browser/frame_host/navigation_entry_impl.cc
('K') |
« content/test/data/navigation_controller/inject_iframe_srcdoc_with_nested_frame.html
('k') |
testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<html>
2
<head></head>
3
<body>
4
<p>This page injects an inner frame into an injected blank iframe.
5
<div id="myDiv"></div>
6
<script>
7
var outerIframeHtml = '<iframe src="about:blank" id="outer"><\/iframe>';
8
var innerIframeHtml = '<iframe src="form.html"><\/iframe>';
9
10
// Create an empty about:blank iframe inside the preexisting div.
11
document.getElementById('myDiv').innerHTML = outerIframeHtml;
12
13
// Populate that empty iframe via doc.write, in a way that causes a request.
14
var iDoc = document.getElementById('outer').contentWindow.document;
15
iDoc.open();
16
iDoc.write(innerIframeHtml);
17
iDoc.close();
18
</script>
19
</body>
20
</html>
OLD
NEW
« content/browser/frame_host/navigation_entry_impl.cc
('K') |
« content/test/data/navigation_controller/inject_iframe_srcdoc_with_nested_frame.html
('k') |
testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter »
('j') |
no next file with comments »
Issue 2438743005: Fix history nav to a script-injected about:blank frame. (Closed)
Created 4 years, 2 months ago by Charlie Reis
Modified 4 years, 2 months ago
Reviewers: alexmos
Base URL:
Comments: 16
This is Rietveld
408576698
Chromium Code Reviews
Issue 2438743005:
Fix history nav to a script-injected about:blank frame. (Closed)
