Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: appengine/findit/waterfall/flake/flake_analysis_service.py

Issue 2438673004: [Findit] Post analysis results of flakes to bug filed by chromium-try-flakes. (Closed)
Patch Set: Add a config flag to enable/disable updating monorail bug. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/flake/flake_analysis_service.py
diff --git a/appengine/findit/waterfall/flake/flake_analysis_service.py b/appengine/findit/waterfall/flake/flake_analysis_service.py
index 9ca5e6e8d46e58de06cfaead18274e6ac28f18c8..304ca4c295b8d9e36d82346235e713bcd1250e94 100644
--- a/appengine/findit/waterfall/flake/flake_analysis_service.py
+++ b/appengine/findit/waterfall/flake/flake_analysis_service.py
@@ -8,6 +8,7 @@ from common import constants
from model.flake.flake_analysis_request import FlakeAnalysisRequest
from waterfall.flake import initialize_flake_pipeline
from waterfall.flake import step_mapper
+from waterfall.test_info import TestInfo
def _CheckFlakeSwarmedAndSupported(request):
@@ -206,12 +207,18 @@ def ScheduleAnalysisForFlake(request, user_email, is_admin, triggering_source):
# A new analysis is needed.
# TODO(lijeffrey): Add support for the force flag to trigger a rerun.
logging.info('A new analysis is needed for: %s', build_step)
- analysis = initialize_flake_pipeline.ScheduleAnalysisIfNeeded(
+ normalized_test = TestInfo(
build_step.wf_master_name, build_step.wf_builder_name,
build_step.wf_build_number, build_step.wf_step_name,
- request.name, allow_new_analysis=True,
- manually_triggered=manually_triggered, user_email=user_email,
- triggering_source=triggering_source,
+ request.name)
+ original_test = TestInfo(
+ build_step.master_name, build_step.builder_name,
+ build_step.build_number, build_step.step_name,
+ request.name)
+ analysis = initialize_flake_pipeline.ScheduleAnalysisIfNeeded(
+ normalized_test, original_test, bug_id=request.bug_id,
+ allow_new_analysis=True, manually_triggered=manually_triggered,
+ user_email=user_email, triggering_source=triggering_source,
queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
if analysis:
# TODO: put this in a transaction.
« no previous file with comments | « appengine/findit/third_party/issue_tracker ('k') | appengine/findit/waterfall/flake/initialize_flake_pipeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698