appengine/findit/waterfall/flake/test/flake_analysis_service_test.py - Issue 2438673004: [Findit] Post analysis results of flakes to bug filed by chromium-try-flakes.

Unified Diff: appengine/findit/waterfall/flake/test/flake_analysis_service_test.py

Issue 2438673004: [Findit] Post analysis results of flakes to bug filed by chromium-try-flakes. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« appengine/findit/waterfall/flake/recursive_flake_pipeline.py ('K') | « appengine/findit/waterfall/flake/recursive_flake_pipeline.py ('k') | appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py » ('j') | appengine/findit/waterfall/post_comment_to_bug_pipeline.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/flake/test/flake_analysis_service_test.py

diff --git a/appengine/findit/waterfall/flake/test/flake_analysis_service_test.py b/appengine/findit/waterfall/flake/test/flake_analysis_service_test.py

index f81964e5c3996b1c40964239050faa982d4fb1da..880b7b70c4575bf945bc48838b04077d0c643595 100644

--- a/appengine/findit/waterfall/flake/test/flake_analysis_service_test.py

+++ b/appengine/findit/waterfall/flake/test/flake_analysis_service_test.py

@@ -10,6 +10,7 @@ from model.flake.flake_analysis_request import BuildStep

from model.flake.flake_analysis_request import FlakeAnalysisRequest

from waterfall.flake import flake_analysis_service

from waterfall.test import wf_testcase

+from waterfall.test_info import TestInfo

class FlakeAnalysisServiceTest(wf_testcase.WaterfallTestCase):

@@ -224,6 +225,9 @@ class FlakeAnalysisServiceTest(wf_testcase.WaterfallTestCase):

mocked_analysis = mock.Mock(key='key')

mocked_request = mock.Mock()

+ normalized_test = TestInfo('wf_m', 'wf_b', 100, 'wf_s', 'flake')

+ original_test = TestInfo('m', 'b', 80, 's', 'flake')

with mock.patch.object(

flake_analysis_service, '_CheckForNewAnalysis',

side_effect=CheckForNewAnalysis) as (

@@ -237,7 +241,7 @@ class FlakeAnalysisServiceTest(wf_testcase.WaterfallTestCase):

request, 'test@chromium.org', True))

mocked_CheckForNewAnalysis.assert_called_once_with(request)

mocked_ScheduleAnalysisIfNeeded.assert_called_once_with(

- 'wf_m', 'wf_b', 100, 'wf_s', 'flake',

+ normalized_test, original_test, bug_id=123,

allow_new_analysis=True, manually_triggered=False,

queue_name=constants.WATERFALL_ANALYSIS_QUEUE)

mocked_GetVersion.assert_called_once_with(key='flake', version=1)

@@ -260,6 +264,8 @@ class FlakeAnalysisServiceTest(wf_testcase.WaterfallTestCase):

step.wf_step_name = 'wf_s'

return 1, step