Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2981)

Unified Diff: appengine/findit/waterfall/flake/flake_analysis_service.py

Issue 2438673004: [Findit] Post analysis results of flakes to bug filed by chromium-try-flakes. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/flake/flake_analysis_service.py
diff --git a/appengine/findit/waterfall/flake/flake_analysis_service.py b/appengine/findit/waterfall/flake/flake_analysis_service.py
index b1ba62540f50da745f723a1252922e5bca375034..bf2e01d8ccfa93158f8cd538c8f3577f4a272952 100644
--- a/appengine/findit/waterfall/flake/flake_analysis_service.py
+++ b/appengine/findit/waterfall/flake/flake_analysis_service.py
@@ -8,6 +8,7 @@ from common import constants
from model.flake.flake_analysis_request import FlakeAnalysisRequest
from waterfall.flake import initialize_flake_pipeline
from waterfall.flake import step_mapper
+from waterfall.test_info import TestInfo
def _CheckFlakeSwarmedAndSupported(request):
@@ -203,11 +204,17 @@ def ScheduleAnalysisForFlake(request, user_email, is_admin):
if version_number and build_step:
# A new analysis is needed.
logging.info('A new analysis is needed for: %s', build_step)
- analysis = initialize_flake_pipeline.ScheduleAnalysisIfNeeded(
+ normalized_test = TestInfo(
build_step.wf_master_name, build_step.wf_builder_name,
build_step.wf_build_number, build_step.wf_step_name,
- request.name, allow_new_analysis=True,
- manually_triggered=manually_triggered,
+ request.name)
+ original_test = TestInfo(
+ build_step.master_name, build_step.builder_name,
+ build_step.build_number, build_step.step_name,
+ request.name)
+ analysis = initialize_flake_pipeline.ScheduleAnalysisIfNeeded(
+ normalized_test, original_test, bug_id=request.bug_id,
+ allow_new_analysis=True, manually_triggered=manually_triggered,
queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
if analysis:
# TODO: put this in a transaction.

Powered by Google App Engine
This is Rietveld 408576698