[Findit] Post analysis results of flakes to bug filed by chromium-try-flakes.

appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 import mock
 
 from common import constants
 from common.pipeline_wrapper import pipeline_handlers
 from model import analysis_status
@@ skipping 145 matching lines @@
     rfp = RecursiveFlakePipeline(
         master_name, builder_name, build_number, step_name, test_name,
         analysis.version_number, master_build_number,
         flakiness_algorithm_results_dict=flakiness_algorithm_results_dict)
 
     rfp.start(queue_name=queue_name)
     self.execute_queued_tasks()
 
   @mock.patch.object(
       recursive_flake_pipeline, '_GetETAToStartAnalysis', return_value=None)
-  def testNextBuildPipelineForNewRecursionFirstFlake(self, _mocked_eta_func):
+  @mock.patch.object(
+      recursive_flake_pipeline, '_UpdateBugWithResult', return_value=None)
+  def testNextBuildPipelineForNewRecursionFirstFlake(self, *_):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
@@ skipping 25 matching lines @@
 
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name, test_name,
         analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertEquals(flakiness_algorithm_results_dict['flakes_in_a_row'], 1)
 
   @mock.patch.object(
       recursive_flake_pipeline, '_GetETAToStartAnalysis', return_value=None)
-  def testNextBuildPipelineForNewRecursionFirstStable(self, _mocked_eta_func):
+  @mock.patch.object(
+      recursive_flake_pipeline, '_UpdateBugWithResult', return_value=None)
+  def testNextBuildPipelineForNewRecursionFirstStable(self, *_):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
@@ skipping 23 matching lines @@
 
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name,
         test_name, analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertEquals(flakiness_algorithm_results_dict['stable_in_a_row'], 1)
 
   @mock.patch.object(
       recursive_flake_pipeline, '_GetETAToStartAnalysis', return_value=None)
-  def testNextBuildPipelineForNewRecursionFlakeInARow(self, _mocked_eta_func):
+  @mock.patch.object(
+      recursive_flake_pipeline, '_UpdateBugWithResult', return_value=None)
+  def testNextBuildPipelineForNewRecursionFlakeInARow(self, *_):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 4,
@@ skipping 24 matching lines @@
 
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name,
         test_name, analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertEquals(flakiness_algorithm_results_dict['stabled_out'], True)
 
   @mock.patch.object(
       recursive_flake_pipeline, '_GetETAToStartAnalysis', return_value=None)
-  def testNextBuildPipelineForNewRecursionStableInARow(self, _mocked_eta_func):
+  @mock.patch.object(
+      recursive_flake_pipeline, '_UpdateBugWithResult', return_value=None)
+  def testNextBuildPipelineForNewRecursionStableInARow(self, *_):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 4,
         'stable_in_a_row': 0,
@@ skipping 24 matching lines @@
 
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name,
         test_name, analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertEquals(flakiness_algorithm_results_dict['flaked_out'], True)
 
   @mock.patch.object(
       recursive_flake_pipeline, '_GetETAToStartAnalysis', return_value=None)
-  def testNextBuildPipelineForNewRecursionLessThanLastBuildNumber(
-      self, _mocked_eta_func):
+  @mock.patch.object(
+      recursive_flake_pipeline, '_UpdateBugWithResult', return_value=None)
+  def testNextBuildPipelineForNewRecursionLessThanLastBuildNumber(self, *_):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
@@ skipping 29 matching lines @@
         recursive_flake_pipeline.RecursiveFlakePipeline, 'start', my_mocked_run)
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name, test_name,
         analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertFalse(queue_name['x'])
 
   @mock.patch.object(
       recursive_flake_pipeline, '_GetETAToStartAnalysis', return_value=None)
-  def testNextBuildPipelineForFailedSwarmingTask(self, _mocked_eta_func):
+  @mock.patch.object(
+      recursive_flake_pipeline, '_UpdateBugWithResult', return_value=None)
+  def testNextBuildPipelineForFailedSwarmingTask(self, *_):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
@@ skipping 29 matching lines @@
     self.mock(
         recursive_flake_pipeline.RecursiveFlakePipeline, 'start', my_mocked_run)
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name, test_name, 1,
         test_result_future, flakiness_algorithm_results_dict)
     self.assertFalse(queue_name['x'])
 
   @mock.patch.object(
       recursive_flake_pipeline, '_GetETAToStartAnalysis', return_value=None)
-  def testNextBuildPipelineForNewRecursionStabledFlakedOut(
-      self, _mocked_eta_func):
+  @mock.patch.object(
+      recursive_flake_pipeline, '_UpdateBugWithResult', return_value=None)
+  def testNextBuildPipelineForNewRecursionStabledFlakedOut(self, *_):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
     queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 4,
@@ skipping 232 matching lines @@
         'upper_boundary': 110,
         'lower_boundary_result': 'STABLE',
         'sequential_run_index': 1
     }
     next_run = sequential_next_run(analysis, flakiness_algorithm_results_dict)
     self.assertEqual(next_run, 102)
     self.assertEqual(analysis.suspected_flake_build_number, None)
 
   @mock.patch.object(
       recursive_flake_pipeline, '_GetETAToStartAnalysis', return_value=None)
-  def testNextBuildPipelineStabledOutFlakedOutFirstTime(self, _mocked_eta_func):
+  @mock.patch.object(
+      recursive_flake_pipeline, '_UpdateBugWithResult', return_value=None)
+  def testNextBuildPipelineStabledOutFlakedOutFirstTime(self, *_):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
@@ skipping 162 matching lines @@
     analysis = MasterFlakeAnalysis.GetVersion(
         master_name, builder_name, master_build_number, step_name, test_name)
     self.assertEqual(analysis_status.COMPLETED, analysis.status)
 
   def testUpdateAnalysisUponCompletionFound(self):
     analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
     analysis.suspected_flake_build_number = 100
     recursive_flake_pipeline._UpdateAnalysisStatusUponCompletion(
         analysis, analysis_status.COMPLETED, None)
     self.assertEqual(analysis.result_status, result_status.FOUND_UNTRIAGED)
+
+  @mock.patch(
+      'waterfall.flake.recursive_flake_pipeline.PostCommentToBugPipeline')
+  def testNotUpdateBugWithResultWithoutAttachedBug(self, mocked_pipeline):
+    master_name = 'm'
+    builder_name = 'b'
+    master_build_number = 100
+    step_name = 's'
+    test_name = 't'
+    analysis = MasterFlakeAnalysis.Create(
+        master_name, builder_name, master_build_number, step_name, test_name)
+    analysis.algorithm_parameters = {'update_monorail_bug': True}
+    self.assertFalse(
+        recursive_flake_pipeline._UpdateBugWithResult(analysis, None))
+    mocked_pipeline.assert_not_called()
+
+  @mock.patch(
+      'waterfall.flake.recursive_flake_pipeline.PostCommentToBugPipeline')
+  def testNotUpdateBugWithResultIfDisabled(self, mocked_pipeline):
+    master_name = 'm'
+    builder_name = 'b'
+    master_build_number = 100
+    step_name = 's'
+    test_name = 't'
+    analysis = MasterFlakeAnalysis.Create(
+        master_name, builder_name, master_build_number, step_name, test_name)
+    analysis.bug_id = 123
+    analysis.algorithm_parameters = {'update_monorail_bug': False}
+    self.assertFalse(
+        recursive_flake_pipeline._UpdateBugWithResult(analysis, None))
+    mocked_pipeline.assert_not_called()
+
+  @mock.patch(
+      'waterfall.flake.recursive_flake_pipeline.PostCommentToBugPipeline')
+  def testUpdateBugWithResultWithAttachedBug(self, mocked_pipeline):
+    mocked_target = mock.Mock()
+    mocked_pipeline.attach_mock(mocked_target, 'target')
+    master_name = 'm'
+    builder_name = 'b'
+    master_build_number = 100
+    step_name = 's'
+    test_name = 't'
+    algorithm_parameters = {
+        'update_monorail_bug': True,
+    }
+    analysis = MasterFlakeAnalysis.Create(
+        master_name, builder_name, master_build_number, step_name, test_name)
+    analysis.algorithm_parameters = algorithm_parameters
+    analysis.bug_id = 123
+    analysis.original_master_name = 'om'
+    analysis.original_builder_name = 'ob'
+    analysis.original_step_name = 'os'
+    self.assertTrue(
+        recursive_flake_pipeline._UpdateBugWithResult(analysis, 'queue'))
+    calls = mocked_pipeline.mock_calls
+    self.assertEqual(2, len(calls))
+
+    _, args, __ = calls[0]
+    bug_id, comment, labels = args
+    self.assertEqual(123, bug_id)
+    self.assertEqual(['AnalyzedByFindit'], labels)
+    self.assertTrue('om / ob / os' in comment)
+
+    self.assertEqual(mock.call().start(queue_name='queue'), calls[1])