[Findit] Post analysis results of flakes to bug filed by chromium-try-flakes.

appengine/findit/handlers/flake/check_flake.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from google.appengine.api import users
+from google.appengine.ext import ndb
 
 from common import auth_util
 from common import constants
 from common import time_util
 from common.base_handler import BaseHandler
 from common.base_handler import Permission
 from model import analysis_status
 from waterfall.flake import initialize_flake_pipeline
+from waterfall.test_info import TestInfo
 
 
 class CheckFlake(BaseHandler):
   PERMISSION_LEVEL = Permission.ANYONE
 
   def HandleGet(self):
-    master_name = self.request.get('master_name').strip()
-    builder_name = self.request.get('builder_name').strip()
-    build_number = int(self.request.get('build_number', '0').strip())
-    step_name = self.request.get('step_name').strip()
-    test_name = self.request.get('test_name').strip()
+    key = self.request.get('key')
+    if key:
+      analysis = ndb.Key(urlsafe=key).get()
+      if not analysis:  # pragma: no cover
+        return self.CreateError('Analysis of flake is not found', 404)
+    else:
+      master_name = self.request.get('master_name').strip()
+      builder_name = self.request.get('builder_name').strip()
+      build_number = int(self.request.get('build_number', '0').strip())
+      step_name = self.request.get('step_name').strip()
+      test_name = self.request.get('test_name').strip()
 
-    if not (master_name and builder_name and build_number and
-            step_name and test_name):  # pragma: no cover.
-      return self.CreateError(
-          'Invalid value of master/builder/build_number/step/test', 400)
+      if not (master_name and builder_name and build_number and
+              step_name and test_name):  # pragma: no cover.
+        return self.CreateError(
+            'Invalid value of master/builder/build_number/step/test', 400)
 
-    force = (auth_util.IsCurrentUserAdmin() and
-             self.request.get('force') == '1')
-    allow_new_analysis = self.IsCorpUserOrAdmin()
+      force = (auth_util.IsCurrentUserAdmin() and
+               self.request.get('force') == '1')
+      allow_new_analysis = self.IsCorpUserOrAdmin()
 
-    analysis = initialize_flake_pipeline.ScheduleAnalysisIfNeeded(
-        master_name, builder_name, build_number, step_name, test_name,
-        allow_new_analysis, force=force, manually_triggered=True,
-        queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
+      test = TestInfo(
+          master_name, builder_name, build_number, step_name, test_name)
+      analysis = initialize_flake_pipeline.ScheduleAnalysisIfNeeded(
+          test, test, allow_new_analysis=allow_new_analysis, force=force,

[lijeffrey, 2016/10/21 17:10:27]

nit: Just so this doesn't look like a typo (because test shows up twice), would
it make sense to rename this 

original_test = TestInfo(...)
normalized_test = original_test
analysis = intitialize_flake_pipeline.ScheduleAnalysisIfNeeded(normalized_test,
original_test, ...)?

[stgao, 2016/10/21 22:42:33]

Done.

[chanli, 2016/10/21 23:23:08]

So when does the normalization happen? For example when is the 'PRE_' prefix
removed?

[stgao, 2016/10/22 00:15:09]

The "PRE_" is a TODO on your end; it's up to you where it should be done. I just
mentioned it as an example for what's normalization.

+          manually_triggered=True,
+          queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
 
-    if not analysis:  # pragma: no cover.
-      return {
-          'template': 'error.html',
-          'data': {
-              'error_message':
-                  ('You could schedule an analysis for flaky test only after '
-                   'you login with google.com account.'),
-              'login_url': self.GetLoginUrl(),
-          },
-          'return_code': 401,
-      }
+      if not analysis:  # pragma: no cover.
+        return {
+            'template': 'error.html',
+            'data': {
+                'error_message':
+                    ('You could schedule an analysis for flaky test only after '
+                     'you login with google.com account.'),
+                'login_url': self.GetLoginUrl(),
+            },
+            'return_code': 401,
+        }
 
     data = {
         'pass_rates': [],
         'analysis_status': analysis.status_description,
         'suspected_flake_build_number': (
             analysis.suspected_flake_build_number),
-        'master_name': master_name,
-        'builder_name': builder_name,
-        'build_number': build_number,
-        'step_name': step_name,
-        'test_name': test_name,
+        'master_name': analysis.master_name,
+        'builder_name': analysis.builder_name,
+        'build_number': analysis.build_number,
+        'step_name': analysis.step_name,
+        'test_name': analysis.test_name,
         'request_time': time_util.FormatDatetime(
             analysis.request_time),
         'task_number': len(analysis.data_points),
         'error': analysis.error_message,
         'iterations_to_rerun': analysis.iterations_to_rerun,
     }
 
     data['pending_time'] = time_util.FormatDuration(
         analysis.request_time,
         analysis.start_time or time_util.GetUTCNow())
     if analysis.status != analysis_status.PENDING:
       data['duration'] = time_util.FormatDuration(
           analysis.start_time,
           analysis.end_time or time_util.GetUTCNow())
 
     coordinates = []
     for data_point in analysis.data_points:
       coordinates.append([data_point.build_number, data_point.pass_rate])
 
     # Order by build number from earliest to latest.
     coordinates.sort(key=lambda x: x[0])
 
     data['pass_rates'] = coordinates
     return {
         'template': 'flake/result.html',
         'data': data
     }