Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1649)

Issue 2438613005: Precache: Optionally rank resources-to-precache globally. (Closed)

Created:
4 years, 2 months ago by twifkak
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Precache: Optionally rank resources-to-precache globally. Added a new global_ranking varation param to the experiment, default false. If specified, the client will multiply each resource weight (a value [0,1]) from the PrecacheManifest by the number of visits to that host -- the result being an estimated likelihood of using that resource. The resources will then be fetched in decreasing order of likelihood. This allows hosts with vastly more visits to fetch more resources than hosts with vastly fewer visits. It also allows mostly-useless resources to bubble down and be replaced by resources for additional hosts. In addition, added a couple new fields to PrecacheConfigurationSettings to tweak its behavior: - total_resources_count is a cap on the total number of resource URLs to fetch - min_weight is a threshold on the minimum likelihood In addition, a few things changed in behavior: - manifests are fetched first, before any resources - the PercentCompleted UMA is measured in % of resource URLs complete rather than % of manifests complete - resource ordering is preserved across pause/resume BUG=654166 Review-Url: https://chromiumcodereview.appspot.com/2403193002 Cr-Commit-Position: refs/heads/master@{#426350} (cherry picked from commit 528a15b56652173bd822ea2a1123e6960ba4f255) Committed: https://chromium.googlesource.com/chromium/src/+/04fc59a0ca84731499f804d2c3aa9fafe4132e06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+641 lines, -211 lines) Patch
M components/precache/content/precache_manager.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M components/precache/core/precache_fetcher.h View 7 chunks +46 lines, -7 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 20 chunks +127 lines, -88 lines 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 32 chunks +430 lines, -107 lines 0 comments Download
M components/precache/core/proto/precache.proto View 2 chunks +16 lines, -0 lines 0 comments Download
M components/precache/core/proto/unfinished_work.proto View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
twifkak
4 years, 2 months ago (2016-10-20 01:57:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04fc59a0ca84731499f804d2c3aa9fafe4132e06.

Powered by Google App Engine
This is Rietveld 408576698