Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2434)

Unified Diff: runtime/bin/vmservice_impl.h

Issue 2438613002: Provide an API to dart:developer to control the web server hosting the Service Protocol (Closed)
Patch Set: CHANGELOG.md merge and fatal error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice_dartium.cc ('k') | runtime/bin/vmservice_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice_impl.h
diff --git a/runtime/bin/vmservice_impl.h b/runtime/bin/vmservice_impl.h
index 5c03c33d19fe667e8c5d0d68be31f14d11e96c4f..f923dcac3c58a8ac58c002642115ec417b7c8ad1 100644
--- a/runtime/bin/vmservice_impl.h
+++ b/runtime/bin/vmservice_impl.h
@@ -24,21 +24,16 @@ class VmService {
// Error message if startup failed.
static const char* GetErrorMessage();
- // HTTP server's IP.
- static const char* GetServerIP() {
- return &server_ip_[0];
- }
-
- // HTTP server's port.
- static intptr_t GetServerPort() {
- return server_port_;
+ // HTTP Server's address.
+ static const char* GetServerAddress() {
+ return &server_uri_[0];
}
private:
- static const intptr_t kServerIpStringBufferSize = 256;
+ static const intptr_t kServerUriStringBufferSize = 1024;
friend void NotifyServerState(Dart_NativeArguments args);
- static void SetServerIPAndPort(const char* ip, intptr_t port);
+ static void SetServerAddress(const char* server_uri_);
static Dart_Handle GetSource(const char* name);
static Dart_Handle LoadScript(const char* name);
static Dart_Handle LoadLibrary(const char* name);
@@ -49,8 +44,7 @@ class VmService {
Dart_Handle url);
static const char* error_msg_;
- static char server_ip_[kServerIpStringBufferSize];
- static intptr_t server_port_;
+ static char server_uri_[kServerUriStringBufferSize];
DISALLOW_ALLOCATION();
DISALLOW_IMPLICIT_CONSTRUCTORS(VmService);
« no previous file with comments | « runtime/bin/vmservice_dartium.cc ('k') | runtime/bin/vmservice_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698