Provide an API to dart:developer to control the web server hosting the Service Protocol

Provide an API to dart:developer to control the web server hosting the Service Protocol

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion;
  /// The minor version of the protocol.
  final int minorVersion;
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

... and add a randomly generated authentication token path prefix that must be passed in to access the service protocol.

Old base url:

Observatory listening on http://127.0.0.1:54804/

New base url:

Observatory listening on http://127.0.0.1:54804/<token>/

For example:

Observatory listening on http://127.0.0.1:54804/PTwjm8Ii8qg=/

Many tools will need to be updated.

Fixes #23320

BUG=
R=asiva@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/63e4f69e5e363e13b193572acb74edc4de99c0e6

[Cutch, 2016-10-19 18:33:06]

Description was changed from

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol

Fixes #23320

BUG=
==========

to

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion = _getServiceMajorVersion();
  /// The minor version of the protocol.
  final int minorVersion = _getServiceMinorVersion();
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

Fixes #23320

BUG=
==========

[Cutch, 2016-10-19 18:33:06]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[Cutch, 2016-10-19 18:33:36]

Description was changed from

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion = _getServiceMajorVersion();
  /// The minor version of the protocol.
  final int minorVersion = _getServiceMinorVersion();
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

Fixes #23320

BUG=
==========

to

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion;
  /// The minor version of the protocol.
  final int minorVersion;
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

Fixes #23320

BUG=
==========

[kevmoo, 2016-10-19 18:51:52]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-10-19 18:51:52]

Excited to see this. Just one doc nit.

https://codereview.chromium.org/2438613002/diff/20001/sdk/lib/developer/servi...
File sdk/lib/developer/service.dart (right):

https://codereview.chromium.org/2438613002/diff/20001/sdk/lib/developer/servi...
sdk/lib/developer/service.dart:46: /// Control the web server that the service
protocol is accessed through.
Explain more here.

does `false` turn it off it's already running?

[nweiz, 2016-10-19 19:19:08]

On 2016/10/19 18:34:00, Cutch wrote:

Where are the tests? Are they coming in a future CL?

[kevmoo, 2016-10-19 19:19:50]

Also: please add an entry to the README

[kevmoo, 2016-10-19 19:19:59]

er, CHANGLOG.md

[Cutch, 2016-10-19 19:25:55]

On 2016/10/19 19:19:08, nweiz wrote:
> On 2016/10/19 18:34:00, Cutch wrote:
> 
> Where are the tests? Are they coming in a future CL?

runtime/observatory/tests/service/developer_server_control_test.dart <---- right
there.

[Cutch, 2016-10-19 21:42:19]

Description was changed from

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion;
  /// The minor version of the protocol.
  final int minorVersion;
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

Fixes #23320

BUG=
==========

to

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol 

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion;
  /// The minor version of the protocol.
  final int minorVersion;
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

... and add a randomly generated authentication token path prefix that must be
passed in to access the service protocol.

Old base url:

Observatory listening on http://127.0.0.1:54804/

New base url:

Observatory listening on http://127.0.0.1:54804/<authentication token>/

For example:

Observatory listening on http://127.0.0.1:54804/PTwjm8Ii8qg=/

Many tools will need to be updated.

Fixes #23320

BUG=
==========

[Cutch, 2016-10-19 21:42:57]

Description was changed from

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol 

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion;
  /// The minor version of the protocol.
  final int minorVersion;
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

... and add a randomly generated authentication token path prefix that must be
passed in to access the service protocol.

Old base url:

Observatory listening on http://127.0.0.1:54804/

New base url:

Observatory listening on http://127.0.0.1:54804/<authentication token>/

For example:

Observatory listening on http://127.0.0.1:54804/PTwjm8Ii8qg=/

Many tools will need to be updated.

Fixes #23320

BUG=
==========

to

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol 

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion;
  /// The minor version of the protocol.
  final int minorVersion;
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

... and add a randomly generated authentication token path prefix that must be
passed in to access the service protocol.

Old base url:

Observatory listening on http://127.0.0.1:54804/

New base url:

Observatory listening on http://127.0.0.1:54804/<token>/

For example:

Observatory listening on http://127.0.0.1:54804/PTwjm8Ii8qg=/

Many tools will need to be updated.

Fixes #23320

BUG=
==========

[kevmoo, 2016-10-19 22:26:56]

https://codereview.chromium.org/2438613002/diff/40001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2438613002/diff/40001/CHANGELOG.md#newcode7
CHANGELOG.md:7: ### Service protocol changes
Thanks!

https://codereview.chromium.org/2438613002/diff/40001/CHANGELOG.md#newcode26
CHANGELOG.md:26: * The service protocol http server can now be controlled from
the
Please add this under new `Core library changes` section after the language
section.

See previous releases for an example

[rmacnak, 2016-10-20 17:12:32]

lgtm

https://chromiumcodereview.appspot.com/2438613002/diff/80001/runtime/bin/vmse...
File runtime/bin/vmservice/server.dart (right):

https://chromiumcodereview.appspot.com/2438613002/diff/80001/runtime/bin/vmse...
runtime/bin/vmservice/server.dart:166: bool _originCheck(HttpRequest request) {
Not in this CL, but perhaps we can remove this browser compensation now.

https://chromiumcodereview.appspot.com/2438613002/diff/80001/runtime/lib/deve...
File runtime/lib/developer.cc (right):

https://chromiumcodereview.appspot.com/2438613002/diff/80001/runtime/lib/deve...
runtime/lib/developer.cc:125: return Smi::New(SERVICE_PROTOCOL_MAJOR_VERSION);
Consider returning 0 in product mode or no service isolate like dart2js

https://chromiumcodereview.appspot.com/2438613002/diff/80001/runtime/observat...
File runtime/observatory/tests/service/developer_server_control_test.dart
(right):

https://chromiumcodereview.appspot.com/2438613002/diff/80001/runtime/observat...
runtime/observatory/tests/service/developer_server_control_test.dart:25:
expect(true, true);
true, isTrue

https://chromiumcodereview.appspot.com/2438613002/diff/80001/sdk/lib/develope...
File sdk/lib/developer/service.dart (right):

https://chromiumcodereview.appspot.com/2438613002/diff/80001/sdk/lib/develope...
sdk/lib/developer/service.dart:9: /// The major version of the protocol.
If the running Dart environment does not support the service protocol, this is
0.

https://chromiumcodereview.appspot.com/2438613002/diff/80001/sdk/lib/vmservic...
File sdk/lib/vmservice/vmservice.dart (right):

https://chromiumcodereview.appspot.com/2438613002/diff/80001/sdk/lib/vmservic...
sdk/lib/vmservice/vmservice.dart:220: Future<Null> _serverMessageHandler(int
code, SendPort sp, bool enable) async {
Future

[kevmoo, 2016-10-20 17:21:55]

one more changelog nit

https://chromiumcodereview.appspot.com/2438613002/diff/80001/CHANGELOG.md
File CHANGELOG.md (right):

https://chromiumcodereview.appspot.com/2438613002/diff/80001/CHANGELOG.md#new...
CHANGELOG.md:31: ### Core library changes
Forgive me – put this section up below Language. Thanks

[Cutch, 2016-10-20 23:31:51]

https://codereview.chromium.org/2438613002/diff/80001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2438613002/diff/80001/CHANGELOG.md#newcode31
CHANGELOG.md:31: ### Core library changes
On 2016/10/20 17:21:55, kevmoo wrote:
> Forgive me – put this section up below Language. Thanks

Done.

https://codereview.chromium.org/2438613002/diff/80001/runtime/bin/vmservice/s...
File runtime/bin/vmservice/server.dart (right):

https://codereview.chromium.org/2438613002/diff/80001/runtime/bin/vmservice/s...
runtime/bin/vmservice/server.dart:166: bool _originCheck(HttpRequest request) {
On 2016/10/20 17:12:31, rmacnak wrote:
> Not in this CL, but perhaps we can remove this browser compensation now.

Acknowledged.

https://codereview.chromium.org/2438613002/diff/80001/runtime/lib/developer.cc
File runtime/lib/developer.cc (right):

https://codereview.chromium.org/2438613002/diff/80001/runtime/lib/developer.c...
runtime/lib/developer.cc:125: return Smi::New(SERVICE_PROTOCOL_MAJOR_VERSION);
On 2016/10/20 17:12:31, rmacnak wrote:
> Consider returning 0 in product mode or no service isolate like dart2js

Done.

https://codereview.chromium.org/2438613002/diff/80001/runtime/observatory/tes...
File runtime/observatory/tests/service/developer_server_control_test.dart
(right):

https://codereview.chromium.org/2438613002/diff/80001/runtime/observatory/tes...
runtime/observatory/tests/service/developer_server_control_test.dart:25:
expect(true, true);
On 2016/10/20 17:12:31, rmacnak wrote:
> true, isTrue

expect(true, true) is equivalent

https://codereview.chromium.org/2438613002/diff/80001/sdk/lib/developer/servi...
File sdk/lib/developer/service.dart (right):

https://codereview.chromium.org/2438613002/diff/80001/sdk/lib/developer/servi...
sdk/lib/developer/service.dart:9: /// The major version of the protocol.
On 2016/10/20 17:12:31, rmacnak wrote:
> If the running Dart environment does not support the service protocol, this is
> 0.

Done.

https://codereview.chromium.org/2438613002/diff/80001/sdk/lib/vmservice/vmser...
File sdk/lib/vmservice/vmservice.dart (right):

https://codereview.chromium.org/2438613002/diff/80001/sdk/lib/vmservice/vmser...
sdk/lib/vmservice/vmservice.dart:220: Future<Null> _serverMessageHandler(int
code, SendPort sp, bool enable) async {
On 2016/10/20 17:12:31, rmacnak wrote:
> Future

Strong mode requires Future<Null> :(

[kevmoo, 2016-10-20 23:57:54]

Oops

https://codereview.chromium.org/2438613002/diff/100001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2438613002/diff/100001/CHANGELOG.md#newcode2
CHANGELOG.md:2: ### Core library changes
Weird!

I think this is a rebase bork.

Lang changes first, then API – please put an empty line after the version

Please mention the APIs added.

Lost all of the details about the service protocol changes

[siva, 2016-10-21 16:15:06]

lgtm

https://codereview.chromium.org/2438613002/diff/100001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2438613002/diff/100001/CHANGELOG.md#newcode8
CHANGELOG.md:8: 
I am wondering about whether we need to highlight this in the release
notes, this is an API we added for consumption by internal tools.

There were some additional version related API functions you added, maybe those
should be added here as well.

https://codereview.chromium.org/2438613002/diff/100001/runtime/bin/vmservice_...
File runtime/bin/vmservice_impl.cc (right):

https://codereview.chromium.org/2438613002/diff/100001/runtime/bin/vmservice_...
runtime/bin/vmservice_impl.cc:290: server_uri_[kServerUriStringBufferSize - 1] =
'\0';
if strlen(server_uri) is > kServerUriStringBufferSize this
ends up truncating the string, is that any useful as we will
be printing/sending a URL string that cannot be used for
connecting.

Why not treat that as an error?

https://codereview.chromium.org/2438613002/diff/100001/runtime/lib/developer.cc
File runtime/lib/developer.cc (right):

https://codereview.chromium.org/2438613002/diff/100001/runtime/lib/developer....
runtime/lib/developer.cc:126: return Smi::New(0);
Shouldn't the product version of these pretty much be UNREACHABLE
as the native resolved (lookupExtension) will not be returning
these entry points in PRODUCT mode.

https://codereview.chromium.org/2438613002/diff/100001/runtime/vm/service.h
File runtime/vm/service.h (right):

https://codereview.chromium.org/2438613002/diff/100001/runtime/vm/service.h#n...
runtime/vm/service.h:17: #define SERVICE_PROTOCOL_MINOR_VERSION 5
Maybe document here the criteria when major version is revised and when minor
version is revised.

[Cutch, 2016-10-31 19:32:28]

Description was changed from

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol 

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion;
  /// The minor version of the protocol.
  final int minorVersion;
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

... and add a randomly generated authentication token path prefix that must be
passed in to access the service protocol.

Old base url:

Observatory listening on http://127.0.0.1:54804/

New base url:

Observatory listening on http://127.0.0.1:54804/<token>/

For example:

Observatory listening on http://127.0.0.1:54804/PTwjm8Ii8qg=/

Many tools will need to be updated.

Fixes #23320

BUG=
==========

to

==========
Provide an API to dart:developer to control the web server hosting the Service
Protocol

- [x] Add `ServiceProtocolnfo` class to dart:developer.
- [x] Add `Service` class to dart:developer.
- [x] Add `Service.getInfo` static method to dart:developer.
- [x] Add `Service.controlWebServer` static method to dart:developer.

API:

```dart

/// Information about the service protocol.
class ServiceProtocolInfo {
  /// The major version of the protocol.
  final int majorVersion;
  /// The minor version of the protocol.
  final int minorVersion;
  /// The Uri to access the service. If the web server is not running, this
  /// will be null.
  final Uri serverUri;
}

/// Access information about the service protocol and control the web server.
class Service {
  /// Get information about the service protocol.
  static Future<ServiceProtocolInfo> getInfo();

  /// Control the web server that the service protocol is accessed through.
  static Future<ServiceProtocolInfo> controlWebServer({bool enable: false});
}
```

... and add a randomly generated authentication token path prefix that must be
passed in to access the service protocol.

Old base url:

Observatory listening on http://127.0.0.1:54804/

New base url:

Observatory listening on http://127.0.0.1:54804/<token>/

For example:

Observatory listening on http://127.0.0.1:54804/PTwjm8Ii8qg=/

Many tools will need to be updated.

Fixes #23320

BUG=
R=asiva@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/63e4f69e5e363e13b193572acb74edc4de99c0e6
==========

[Cutch, 2016-10-31 19:32:29]

Committed patchset #7 (id:120001) manually as
63e4f69e5e363e13b193572acb74edc4de99c0e6 (presubmit successful).