Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2438563004: [Android] Always use devil's adb in the perf recipes. (RELAND) (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 2 months ago
CC:
chromium-reviews, nednguyen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Always use devil's adb in the perf recipes. (RELAND) BUG=623989 Committed: https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91 Cr-Commit-Position: refs/heads/master@{#426569}

Patch Set 1 : original #

Patch Set 2 : revised: prefetch adb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1003 lines, -375 lines) Patch
M infra/recipes/android/perf.py View 1 1 chunk +16 lines, -0 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 1 13 chunks +30 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 1 13 chunks +30 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 1 13 chunks +30 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json View 1 13 chunks +30 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json View 1 13 chunks +30 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json View 1 13 chunks +30 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/get_perf_test_list_old_data.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/host_info_failure.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/missing_device.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/provision_devices.json View 1 7 chunks +24 lines, -6 lines 0 comments Download
M infra/recipes/android/perf.expected/src_side_script_fails.json View 1 12 chunks +29 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/test_failure.json View 1 12 chunks +29 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jbudorick
requires https://codereview.chromium.org/2438753002/
4 years, 2 months ago (2016-10-20 14:37:28 UTC) #2
ghost stip (do not use)
lgtm
4 years, 2 months ago (2016-10-20 16:44:05 UTC) #3
dtu
lgtm
4 years, 2 months ago (2016-10-20 19:35:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438563004/20001
4 years, 2 months ago (2016-10-20 19:38:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 19:51:41 UTC) #7
jbudorick
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2434403002/ by jbudorick@chromium.org. ...
4 years, 2 months ago (2016-10-20 22:40:04 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:21:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91
Cr-Commit-Position: refs/heads/master@{#426569}

Powered by Google App Engine
This is Rietveld 408576698