Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2438543004: Improve condition strengthening for last test in short-circuit. (Closed)

Created:
4 years, 2 months ago by sra1
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve condition strengthening for last test in short-circuit. This strengthens t1 = s == null || t == null; if (t1) return; known-here: t != null There are not many hits since the 'interesting' tests are usually earlier in the short-circuit expression. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7eaad70e2fdbf9dc118e3243877761f7632b9095

Patch Set 1 #

Patch Set 2 : fix assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -32 lines) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 1 2 chunks +41 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years, 2 months ago (2016-10-21 04:50:53 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
4 years, 2 months ago (2016-10-21 14:31:15 UTC) #3
sra1
4 years, 1 month ago (2016-10-25 11:48:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7eaad70e2fdbf9dc118e3243877761f7632b9095 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698