Source/modules/crypto/CryptoResultImpl.h - Issue 243853004: [webcrypto] Reject failed operations with a DOMException rather than null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/crypto/CryptoResultImpl.h

Issue 243853004: [webcrypto] Reject failed operations with a DOMException rather than null. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix compile warning Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/crypto/CryptoResultImpl.h

diff --git a/Source/modules/crypto/CryptoResultImpl.h b/Source/modules/crypto/CryptoResultImpl.h

index 94df5aabaf0f2e8c4746acca157963a5b30233e8..9d654d363ac1c8629fa12bf490dc5b8b9a29bef0 100644

--- a/Source/modules/crypto/CryptoResultImpl.h

+++ b/Source/modules/crypto/CryptoResultImpl.h

@@ -55,8 +55,7 @@ public:

static PassRefPtr<CryptoResultImpl> create();

- virtual void completeWithError() OVERRIDE;

- virtual void completeWithError(const blink::WebString&) OVERRIDE;

+ virtual void completeWithError(blink::WebCryptoErrorType, const blink::WebString&) OVERRIDE;

virtual void completeWithBuffer(const blink::WebArrayBuffer&) OVERRIDE;

virtual void completeWithBoolean(bool) OVERRIDE;

virtual void completeWithKey(const blink::WebCryptoKey&) OVERRIDE;