Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: LayoutTests/crypto/sign-verify-badParameters.html

Issue 243853004: [webcrypto] Reject failed operations with a DOMException rather than null. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix compile warning Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/crypto/sign-verify-badParameters.html
diff --git a/LayoutTests/crypto/sign-verify-badParameters.html b/LayoutTests/crypto/sign-verify-badParameters.html
index 252de91485635a33031dc755346eea4ded1597d1..458acd28dcff92680a159b02fff01f25fa2ae564 100644
--- a/LayoutTests/crypto/sign-verify-badParameters.html
+++ b/LayoutTests/crypto/sign-verify-badParameters.html
@@ -32,33 +32,28 @@ importHmacKey().then(function(result) {
// Pass invalid signature parameters to verify()
return crypto.subtle.verify(hmac, key, null, data);
}).then(failAndFinishJSTest, function(result) {
- error = result;
- shouldBeNull("error");
+ logError(result);
// Pass invalid signature parameters to verify()
return crypto.subtle.verify(hmac, key, 'a', data);
}).then(failAndFinishJSTest, function(result) {
- error = result;
- shouldBeNull("error");
+ logError(result);
// Pass invalid signature parameters to verify()
return crypto.subtle.verify(hmac, key, [], data);
}).then(failAndFinishJSTest, function(result) {
- error = result;
- shouldBeNull("error");
+ logError(result);
// Operation does not support signing.
return crypto.subtle.sign({name: 'sha-1'}, key, data);
}).then(failAndFinishJSTest, function(result) {
- error = result;
- shouldBeNull("error");
+ logError(result);
// Operation doesn't support signing (also given an invalid key, but the
// first failure takes priority)
return crypto.subtle.sign({name: 'RSAES-PKCS1-v1_5'}, key, data);
}).then(failAndFinishJSTest, function(result) {
- error = result;
- shouldBeNull("error");
+ logError(result);
}).then(finishJSTest, failAndFinishJSTest);
</script>

Powered by Google App Engine
This is Rietveld 408576698