Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2485)

Unified Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.js

Issue 2438443005: MD Settings: Date and Time page, part 2/3 (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.js
diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js b/chrome/browser/resources/settings/controls/settings_dropdown_menu.js
index 06061fbffc0d797738e2980f8d4ea43bbf9e7498..b73c4c8fa62acd8296dcee67764979d4748198c1 100644
--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js
+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.js
@@ -102,9 +102,14 @@ Polymer({
// Need to wait for the dom-repeat to render, before assigning a value to
// |selected_|, otherwise select#value is not populated correctly.
this.async(function() {
- this.selected_ = option == undefined ?
+ var newSelected = option == undefined ?
this.notFoundValue_ :
Settings.PrefUtil.prefToString(assert(this.pref));
+
+ // Ensure Polymer recognizes that selected_ changes.
+ if (newSelected == this.selected_)
+ this.selected_ = '';
stevenjb 2016/10/21 20:16:40 Eww. Can we do: if( == ) this.notifyPath('select
michaelpg 2016/10/25 00:35:15 Found a correct-er fix and rebased this patch on t
+ this.selected_ = newSelected;
}.bind(this));
},

Powered by Google App Engine
This is Rietveld 408576698