Chromium Code Reviews| Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.js |
| diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js b/chrome/browser/resources/settings/controls/settings_dropdown_menu.js |
| index 06061fbffc0d797738e2980f8d4ea43bbf9e7498..b73c4c8fa62acd8296dcee67764979d4748198c1 100644 |
| --- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js |
| +++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.js |
| @@ -102,9 +102,14 @@ Polymer({ |
| // Need to wait for the dom-repeat to render, before assigning a value to |
| // |selected_|, otherwise select#value is not populated correctly. |
| this.async(function() { |
| - this.selected_ = option == undefined ? |
| + var newSelected = option == undefined ? |
| this.notFoundValue_ : |
| Settings.PrefUtil.prefToString(assert(this.pref)); |
| + |
| + // Ensure Polymer recognizes that selected_ changes. |
| + if (newSelected == this.selected_) |
| + this.selected_ = ''; |
|
stevenjb
2016/10/21 20:16:40
Eww. Can we do:
if( == )
this.notifyPath('select
michaelpg
2016/10/25 00:35:15
Found a correct-er fix and rebased this patch on t
|
| + this.selected_ = newSelected; |
| }.bind(this)); |
| }, |