chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java - Issue 2438413002: [Offline pages] Reinstating the offline icon on tablet and fixing verbose state/URL emphasis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java

Issue 2438413002: [Offline pages] Reinstating the offline icon on tablet and fixing verbose state/URL emphasis (Closed)

Patch Set: Addressing comments and fixing compilation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java

index 3f42afcc3cd9b9fabf3632e35372d5093574377d..8f1cbb25f188c20381cb4b77a6755c0a4eaa44ee 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java

@@ -150,7 +150,7 @@ public class WebappUrlBar extends FrameLayout implements View.OnLayoutChangeList

private void updateSecurityIcon(int securityLevel) {

boolean isSmallDevice = !DeviceFormFactor.isTablet(getContext());

mCurrentIconResource =

- LocationBarLayout.getSecurityIconResource(securityLevel, isSmallDevice);

+ LocationBarLayout.getSecurityIconResource(securityLevel, isSmallDevice, false);

if (mCurrentIconResource != 0 && mIconResourceWidths.get(mCurrentIconResource, -1) == -1) {

Drawable icon = ApiCompatibilityUtils.getDrawable(getResources(), mCurrentIconResource);