Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2438393002: Change logging of specific tests and builds to rebaseline to debug level. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
wkorman, jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change logging of specific tests and builds to rebaseline to debug level. This is a non-urgent minor change in `webkit-patch rebaseline-cl` that would make it a little less verbose. Right now when you run `webkit-patch rebaseline-cl` by default it prints the list of tests to rebaseline twice: once before starting, listing specific builds, and once when actually downloading baselines. After this CL, the more specific information (which builds are used) is only printed when --verbose is passed, and the default behavior is less verbose. Committed: https://crrev.com/8bcc01aa1b435f49edbfe2ffdfa640b1b8f09200 Cr-Commit-Position: refs/heads/master@{#427004}

Patch Set 1 #

Patch Set 2 : print each build on a separate line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
4 years, 2 months ago (2016-10-21 20:53:13 UTC) #3
jeffcarp
lgtm
4 years, 2 months ago (2016-10-21 22:39:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438393002/20001
4 years, 2 months ago (2016-10-23 19:48:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-23 20:38:52 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-23 20:41:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8bcc01aa1b435f49edbfe2ffdfa640b1b8f09200
Cr-Commit-Position: refs/heads/master@{#427004}

Powered by Google App Engine
This is Rietveld 408576698