Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2438383003: Fix undefined shift in DiyFpStrtod. (Closed)

Created:
4 years, 2 months ago by esprehn
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix undefined shift in DiyFpStrtod. This code is just copy pasta from v8, this patch copies a newer version of the pasta. https://chromium.googlesource.com/v8/v8/+/374a4da83e6f4e05d31640b23b5ca92f0bbf0586/src/strtod.cc#249 BUG=637044, 629034 Committed: https://crrev.com/d74c8d750deee3b9412b978b1dc49e2d3f0d75d6 Cr-Commit-Position: refs/heads/master@{#426973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/wtf/dtoa/strtod.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
esprehn
4 years, 2 months ago (2016-10-21 23:15:37 UTC) #4
Jeffrey Yasskin
lgtm
4 years, 2 months ago (2016-10-21 23:29:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438383003/1
4 years, 2 months ago (2016-10-22 02:21:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-22 04:47:55 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 04:57:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d74c8d750deee3b9412b978b1dc49e2d3f0d75d6
Cr-Commit-Position: refs/heads/master@{#426973}

Powered by Google App Engine
This is Rietveld 408576698