Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2438373002: arc: bluetooth: Set advertisement max slot to 1 (Closed)

Created:
4 years, 1 month ago by puthik_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, Rahul Chaturvedi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: bluetooth: Set advertisement max slot to 1 CTS Verifier want us to also support multiple signal strength when we declared that multi-advertisement is supported. Disable multiadvertisement until that is done. BUG=658387, 658385 TEST=CTS Verifier LE signal strength test won't show up Committed: https://crrev.com/4438f8fe974c55d1d8c4f515feab9763aad2b530 Cr-Commit-Position: refs/heads/master@{#426958}

Patch Set 1 #

Patch Set 2 : remove unit test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -56 lines) Patch
M components/arc/bluetooth/arc_bluetooth_bridge.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc View 1 1 chunk +0 lines, -55 lines 1 comment Download

Messages

Total messages: 20 (10 generated)
puthik_chromium
CC: steel / lhchavez Luis is in Tokyo so send this to Elijah instead.
4 years, 1 month ago (2016-10-21 20:13:00 UTC) #2
Rahul Chaturvedi
lgtm
4 years, 1 month ago (2016-10-21 20:24:19 UTC) #6
elijahtaylor1
lgtm
4 years, 1 month ago (2016-10-21 20:34:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438373002/1
4 years, 1 month ago (2016-10-21 20:38:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/258225)
4 years, 1 month ago (2016-10-21 21:49:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438373002/20001
4 years, 1 month ago (2016-10-22 00:54:29 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-22 02:50:23 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4438f8fe974c55d1d8c4f515feab9763aad2b530 Cr-Commit-Position: refs/heads/master@{#426958}
4 years, 1 month ago (2016-10-22 02:54:50 UTC) #18
elijahtaylor1
https://codereview.chromium.org/2438373002/diff/20001/components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc File components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc (left): https://codereview.chromium.org/2438373002/diff/20001/components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc#oldcode333 components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc:333: TEST_F(ArcBluetoothBridgeTest, MultiAdvertisement) { For future reference, you could have ...
4 years, 1 month ago (2016-10-22 04:04:56 UTC) #19
elijahtaylor1
4 years, 1 month ago (2016-10-22 04:05:02 UTC) #20
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698