third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc - Issue 2438313003: [LayoutNG] Remove derived constraint spaces from opportunity iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

Issue 2438313003: [LayoutNG] Remove derived constraint spaces from opportunity iterator. (Closed)

Patch Set: .. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h » ('j') | third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

index 04022dd323400ab783606dab40a89b20c93f60fc..7db8a8c5feb824801f1b012690dd6578bf30b6a1 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

@@ -44,7 +44,7 @@ TEST(NGConstraintSpaceTest, WritingMode) {

EXPECT_EQ(FragmentNone, vert_space->BlockFragmentationType());

}

-static String OpportunityToString(const NGConstraintSpace* opportunity) {

+static String OpportunityToString(const NGLogicalRect* opportunity) {

return opportunity ? opportunity->ToString() : String("(null)");

}