Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.cc

Issue 2438313003: [LayoutNG] Remove derived constraint spaces from opportunity iterator. (Closed)
Patch Set: address comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.cc
index b6e87f5611da6b3c75ecfea43dcb0e8745eb866f..8762a06fe65defffd9209f80bcf9dcaccd50444c 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.cc
@@ -10,19 +10,18 @@
namespace blink {
NGLayoutOpportunityTreeNode::NGLayoutOpportunityTreeNode(
- const NGConstraintSpace* space)
- : space(space) {
- exclusion_edge.start = space->Offset().inline_offset;
- exclusion_edge.end = exclusion_edge.start + space->Size().inline_size;
+ const NGLogicalRect opportunity)
+ : opportunity(opportunity) {
+ exclusion_edge.start = opportunity.offset.inline_offset;
+ exclusion_edge.end = exclusion_edge.start + opportunity.size.inline_size;
}
NGLayoutOpportunityTreeNode::NGLayoutOpportunityTreeNode(
- NGConstraintSpace* space,
+ const NGLogicalRect opportunity,
NGEdge exclusion_edge)
- : space(space), exclusion_edge(exclusion_edge) {}
+ : opportunity(opportunity), exclusion_edge(exclusion_edge) {}
DEFINE_TRACE(NGLayoutOpportunityTreeNode) {
- visitor->trace(space);
visitor->trace(left);
visitor->trace(bottom);
visitor->trace(right);

Powered by Google App Engine
This is Rietveld 408576698