Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

Issue 2438313003: [LayoutNG] Remove derived constraint spaces from opportunity iterator. (Closed)
Patch Set: address comments? Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NGConstraintSpace_h 5 #ifndef NGConstraintSpace_h
6 #define NGConstraintSpace_h 6 #define NGConstraintSpace_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/layout/ng/ng_physical_constraint_space.h" 9 #include "core/layout/ng/ng_physical_constraint_space.h"
10 #include "core/layout/ng/ng_writing_mode.h" 10 #include "core/layout/ng/ng_writing_mode.h"
(...skipping 23 matching lines...) Expand all
34 // NGPhysicalConstraintSpace. Sets this constraint space's size to the 34 // NGPhysicalConstraintSpace. Sets this constraint space's size to the
35 // physical constraint space's container size, converted to logical 35 // physical constraint space's container size, converted to logical
36 // coordinates. 36 // coordinates.
37 // TODO(layout-ng): Do we need this constructor? 37 // TODO(layout-ng): Do we need this constructor?
38 NGConstraintSpace(NGWritingMode, NGDirection, NGPhysicalConstraintSpace*); 38 NGConstraintSpace(NGWritingMode, NGDirection, NGPhysicalConstraintSpace*);
39 39
40 // Constructs a constraint space with a different NGWritingMode and 40 // Constructs a constraint space with a different NGWritingMode and
41 // NGDirection that's otherwise identical. 41 // NGDirection that's otherwise identical.
42 NGConstraintSpace(NGWritingMode, NGDirection, const NGConstraintSpace*); 42 NGConstraintSpace(NGWritingMode, NGDirection, const NGConstraintSpace*);
43 43
44 // Constructs a derived constraint space sharing the same backing
45 // NGPhysicalConstraintSpace, NGWritingMode and NGDirection. Primarily for use
46 // by NGLayoutOpportunityIterator.
47 NGConstraintSpace(const NGConstraintSpace& other,
48 NGLogicalOffset,
49 NGLogicalSize);
50
51 // Constructs a derived constraint space that shares the exclusions of the 44 // Constructs a derived constraint space that shares the exclusions of the
52 // input constraint space, but has a different container size, writing mode 45 // input constraint space, but has a different container size, writing mode
53 // and direction. Sets the offset to zero. For use by layout algorithms 46 // and direction. Sets the offset to zero. For use by layout algorithms
54 // to use as the basis to find layout opportunities for children. 47 // to use as the basis to find layout opportunities for children.
55 NGConstraintSpace(NGWritingMode, 48 NGConstraintSpace(NGWritingMode,
56 NGDirection, 49 NGDirection,
57 const NGConstraintSpace& other, 50 const NGConstraintSpace& other,
58 NGLogicalSize); 51 NGLogicalSize);
59 52
60 // This should live on NGBox or another layout bridge and probably take a root 53 // This should live on NGBox or another layout bridge and probably take a root
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 }; 129 };
137 130
138 inline std::ostream& operator<<(std::ostream& stream, 131 inline std::ostream& operator<<(std::ostream& stream,
139 const NGConstraintSpace& value) { 132 const NGConstraintSpace& value) {
140 return stream << value.ToString(); 133 return stream << value.ToString();
141 } 134 }
142 135
143 } // namespace blink 136 } // namespace blink
144 137
145 #endif // NGConstraintSpace_h 138 #endif // NGConstraintSpace_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698