Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2438313003: [LayoutNG] Remove derived constraint spaces from opportunity iterator. (Closed)
Patch Set: address comments? Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_constraint_space.h" 5 #include "core/layout/ng/ng_constraint_space.h"
6 6
7 #include "core/layout/LayoutBlock.h" 7 #include "core/layout/LayoutBlock.h"
8 #include "core/layout/LayoutView.h" 8 #include "core/layout/LayoutView.h"
9 #include "core/layout/ng/ng_layout_opportunity_iterator.h" 9 #include "core/layout/ng/ng_layout_opportunity_iterator.h"
10 #include "core/layout/ng/ng_units.h" 10 #include "core/layout/ng/ng_units.h"
(...skipping 19 matching lines...) Expand all
30 30
31 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode, 31 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
32 NGDirection direction, 32 NGDirection direction,
33 const NGConstraintSpace* constraint_space) 33 const NGConstraintSpace* constraint_space)
34 : physical_space_(constraint_space->PhysicalSpace()), 34 : physical_space_(constraint_space->PhysicalSpace()),
35 offset_(constraint_space->Offset()), 35 offset_(constraint_space->Offset()),
36 size_(constraint_space->Size()), 36 size_(constraint_space->Size()),
37 writing_mode_(writing_mode), 37 writing_mode_(writing_mode),
38 direction_(direction) {} 38 direction_(direction) {}
39 39
40 NGConstraintSpace::NGConstraintSpace(const NGConstraintSpace& other,
41 NGLogicalOffset offset,
42 NGLogicalSize size)
43 : physical_space_(other.PhysicalSpace()),
44 offset_(offset),
45 size_(size),
46 writing_mode_(other.WritingMode()),
47 direction_(other.Direction()) {}
48
49 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode, 40 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
50 NGDirection direction, 41 NGDirection direction,
51 const NGConstraintSpace& other, 42 const NGConstraintSpace& other,
52 NGLogicalSize size) 43 NGLogicalSize size)
53 : size_(size), writing_mode_(writing_mode), direction_(direction) { 44 : size_(size), writing_mode_(writing_mode), direction_(direction) {
54 physical_space_ = 45 physical_space_ =
55 new NGPhysicalConstraintSpace(size.ConvertToPhysical(writing_mode)); 46 new NGPhysicalConstraintSpace(size.ConvertToPhysical(writing_mode));
56 for (const auto& exclusion : other.PhysicalSpace()->Exclusions()) { 47 for (const auto& exclusion : other.PhysicalSpace()->Exclusions()) {
57 physical_space_->AddExclusion(exclusion); 48 physical_space_->AddExclusion(exclusion);
58 } 49 }
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 183
193 String NGConstraintSpace::ToString() const { 184 String NGConstraintSpace::ToString() const {
194 return String::format("%s,%s %sx%s", 185 return String::format("%s,%s %sx%s",
195 offset_.inline_offset.toString().ascii().data(), 186 offset_.inline_offset.toString().ascii().data(),
196 offset_.block_offset.toString().ascii().data(), 187 offset_.block_offset.toString().ascii().data(),
197 size_.inline_size.toString().ascii().data(), 188 size_.inline_size.toString().ascii().data(),
198 size_.block_size.toString().ascii().data()); 189 size_.block_size.toString().ascii().data());
199 } 190 }
200 191
201 } // namespace blink 192 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698