Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2438293002: Don't assume python is in /usr/bin in js_minify.py (Closed)

Created:
4 years, 2 months ago by wonko
Modified:
4 years, 1 month ago
Reviewers:
aberent, Dan Beam
CC:
chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't assume python is in /usr/bin in js_minify.py BUG=658218 Committed: https://crrev.com/f98d771de02d93a8bf4b01e8800516469677b90f Cr-Commit-Position: refs/heads/master@{#427304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/closure_compiler/js_minify.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
wonko
@reviewer: does this patch look OK to you?
4 years, 2 months ago (2016-10-21 12:55:26 UTC) #3
fs
4 years, 2 months ago (2016-10-21 13:19:23 UTC) #6
fs
4 years, 2 months ago (2016-10-21 13:19:32 UTC) #8
Dan Beam
lgtm
4 years, 1 month ago (2016-10-24 22:53:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438293002/1
4 years, 1 month ago (2016-10-25 07:26:25 UTC) #14
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years, 1 month ago (2016-10-25 08:33:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438293002/1
4 years, 1 month ago (2016-10-25 09:11:31 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 09:43:21 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 09:47:36 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f98d771de02d93a8bf4b01e8800516469677b90f
Cr-Commit-Position: refs/heads/master@{#427304}

Powered by Google App Engine
This is Rietveld 408576698