Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Issue 2438253002: binding: Creates a reject promise always in the current realm. (Closed)

Created:
4 years, 2 months ago by Yuki
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

binding: Creates a reject promise always in the current realm. Regular promises are created in the relevant real of the context object. However, reject promises are special, they must be created in the current realm as same as exceptions must be created in the current realm. BUG=656274 Review-Url: https://chromiumcodereview.appspot.com/2418413004 Cr-Commit-Position: refs/heads/master@{#426171} (cherry picked from commit 9e04d69152b9c2ac7b4e395213c0e19c52e69bcc) Committed: https://chromium.googlesource.com/chromium/src/+/4152354ad141e5f759ee0d80a95b1a8bb49143e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -16 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/promise-realm.html View 1 chunk +67 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/GeneratedCodeHelper.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Yuki
4 years, 2 months ago (2016-10-21 07:13:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4152354ad141e5f759ee0d80a95b1a8bb49143e7.

Powered by Google App Engine
This is Rietveld 408576698