Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2438233004: Make IndexedDBConnection IDs independent from the IPC database ID. (Closed)

Created:
4 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
kenrb, jsbell
CC:
chromium-reviews, cmumford, darin-cc_chromium.org, jam, jsbell+idb_chromium.org, dmurph
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make IndexedDBConnection IDs independent from the IPC database ID. I'm removing the IPC database ID as part of the Mojo conversion so reusing it for the IndexedDBConnection ID just makes things confusing. Note that the database observer IPCs don't actually make use of this ID so this patch stops sending it. BUG=627484 Committed: https://crrev.com/ef35213f198a8ce5a59e3c1b74afa858587c61c9 Cr-Commit-Position: refs/heads/master@{#427117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M content/browser/indexed_db/indexed_db_connection.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_connection.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 2 months ago (2016-10-22 00:55:51 UTC) #4
jsbell
lgtm (dmurph@ - FYI)
4 years, 1 month ago (2016-10-24 16:51:52 UTC) #7
kenrb
ipc lgtm
4 years, 1 month ago (2016-10-24 17:02:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438233004/1
4 years, 1 month ago (2016-10-24 17:03:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 19:37:06 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 19:55:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef35213f198a8ce5a59e3c1b74afa858587c61c9
Cr-Commit-Position: refs/heads/master@{#427117}

Powered by Google App Engine
This is Rietveld 408576698