Migrate WindowServerTestBase to be a WM client.

Make WindowServerTestBase connect as WM client.

WindowServerTestBase already implements the WindowManagerDelegate
interface to be a WM client. Instead of connecting to service:ui as a WM
client, it connects using mojom::WindowTreeHost. This interface is only
used in tests and doesn't exercise the real display codepath in
service:ui.

Change WindowServerTestBase to connect WM client. The first response
that it receives will be in OnWmNewDisplay() instead of OnEmbed(), so
move call QuitRunLoop() to OnWmNewDisplay() as well.

BUG=none

Committed: https://crrev.com/919090e7946b429d0854602d711ccf9215c4d279
Cr-Commit-Position: refs/heads/master@{#427159}

[kylechar, 2016-10-21 20:21:00]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 20:21:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 21:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 21:40:13]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-10-24 13:36:55]

Description was changed from

==========
Migrate WindowServerTestBase to be a WM client.

WindowServerTestBase already implements all of the necessary methods.
This change will have tests based on WindowServerTestBase use the same
display codepath as mustash instead of test only codepath that
WindowTreeHost ends up in.

BUG=none
==========

to

==========
Make WindowServerTestBase connect as WM client.

WindowServerTestBase already implements the WindowManagerDelegate
interface to be a WM client. Instead of connecting to service:ui as a WM
client, it connects using mojom::WindowTreeHost. This interface is only
used in tests and doesn't exercise the real display codepath in
service:ui.

Change WindowServerTestBase to connect WM client. The first response
that it receives will be in OnWmNewDisplay() instead of OnEmbed(), so
move call QuitRunLoop() to OnWmNewDisplay() as well.

BUG=none
==========

[kylechar, 2016-10-24 13:37:07]

kylechar@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-10-24 18:58:35]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-10-24 18:58:35]

Scott would be a much better reviewer here, sorry :-/

[sky, 2016-10-24 20:18:14]

LGTM

[kylechar, 2016-10-24 20:18:34]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-10-24 20:19:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 21:42:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-24 21:46:02]

Description was changed from

==========
Make WindowServerTestBase connect as WM client.

WindowServerTestBase already implements the WindowManagerDelegate
interface to be a WM client. Instead of connecting to service:ui as a WM
client, it connects using mojom::WindowTreeHost. This interface is only
used in tests and doesn't exercise the real display codepath in
service:ui.

Change WindowServerTestBase to connect WM client. The first response
that it receives will be in OnWmNewDisplay() instead of OnEmbed(), so
move call QuitRunLoop() to OnWmNewDisplay() as well.

BUG=none
==========

to

==========
Make WindowServerTestBase connect as WM client.

WindowServerTestBase already implements the WindowManagerDelegate
interface to be a WM client. Instead of connecting to service:ui as a WM
client, it connects using mojom::WindowTreeHost. This interface is only
used in tests and doesn't exercise the real display codepath in
service:ui.

Change WindowServerTestBase to connect WM client. The first response
that it receives will be in OnWmNewDisplay() instead of OnEmbed(), so
move call QuitRunLoop() to OnWmNewDisplay() as well.

BUG=none

Committed: https://crrev.com/919090e7946b429d0854602d711ccf9215c4d279
Cr-Commit-Position: refs/heads/master@{#427159}
==========

[commit-bot: I haz the power, 2016-10-24 21:46:03]

Patchset 1 (id:??) landed as
https://crrev.com/919090e7946b429d0854602d711ccf9215c4d279
Cr-Commit-Position: refs/heads/master@{#427159}