WebRTC: Use Chromium's GTestTest for Android

WebRTC: Use Chromium's GTestTest for Android

BUG=657725
Committed: https://chromium.googlesource.com/chromium/tools/build/+/9d6efc40b3fa6c70485e1d15c52e5611a8e83e78

[ehmaldonado_chromium, 2016-10-21 13:59:56]

Patchset #1 (id:1) has been deleted

[ehmaldonado_chromium, 2016-10-21 14:02:09]

ehmaldonado@chromium.org changed reviewers:
+ kjellander@chromium.org

[ehmaldonado_chromium, 2016-10-21 14:02:09]

I'm not sure about the differences in the expectations.
I'll read the recipes more carefully, but maybe you know someone who knows more
about this?

[kjellander_chromium, 2016-10-21 14:08:44]

kjellander@chromium.org changed reviewers:
+ iannucci@chromium.org

[kjellander_chromium, 2016-10-21 14:08:44]

I think it looks good, but it's better Robbie reviews this.
I'm afraid they don't like the import DEPS part... but I'm not sure there's
another way.

[iannucci, 2016-10-24 17:25:21]

I think the followup_annotation changes are just because you're changing the
test class from Test to GTestTest, which omits that json file as a link on the
waterfall.

https://codereview.chromium.org/2438173004/diff/10001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/steps.py (right):

https://codereview.chromium.org/2438173004/diff/10001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/steps.py:8: def generate_tests(api,
test_suite, revision, enable_swarming=False):
I think that api.chromium_tests.steps.GTestTest would be the same object, and
wouldn't require your import hack.

[ehmaldonado_chromium, 2016-10-25 08:00:23]

PTAL.

https://codereview.chromium.org/2438173004/diff/30001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/steps.py (right):

https://codereview.chromium.org/2438173004/diff/30001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/steps.py:41: GTestTest =
api.m.chromium_tests.steps.GTestTest
Is this OK?
Using api.m.chromium_tests.steps.GTestTest would make the line below too long.

[kjellander_chromium, 2016-10-25 08:34:26]

lgtm, and now that we know Robbie has looked at it, you can commit (since I'm
OWNER in all these dirs).

https://codereview.chromium.org/2438173004/diff/30001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/steps.py (right):

https://codereview.chromium.org/2438173004/diff/30001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/steps.py:41: GTestTest =
api.m.chromium_tests.steps.GTestTest
On 2016/10/25 08:00:23, ehmaldonado_chromium wrote:
> Is this OK?
> Using api.m.chromium_tests.steps.GTestTest would make the line below too long.

I prefer this, yes.

[ehmaldonado_chromium, 2016-10-25 08:54:52]

The CQ bit was checked by ehmaldonado@chromium.org

[ehmaldonado_chromium, 2016-10-25 08:54:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@chromium.org
Link to the patchset: https://codereview.chromium.org/2438173004/#ps50001
(title: "Rebasing to be sure.")

[commit-bot: I haz the power, 2016-10-25 08:55:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 09:05:05]

Description was changed from

==========
WebRTC: Use Chromium's GTestTest for Android

BUG=657725
==========

to

==========
WebRTC: Use Chromium's GTestTest for Android

BUG=657725

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/9d6efc40b3fa6c70485e...
==========

[commit-bot: I haz the power, 2016-10-25 09:05:06]

Committed patchset #3 (id:50001) as
https://chromium.googlesource.com/chromium/tools/build/+/9d6efc40b3fa6c70485e...