[Reland] Upgrade to new Android SDK.

[Reland] Upgrade to new Android SDK.

https://codereview.chromium.org/2350013004/ was reverted due to breakage on the perf waterfall. After https://codereview.chromium.org/2438563004/, this should hopefully be resolved.

BUG=623989
Committed: https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788
Cr-Commit-Position: refs/heads/master@{#426777}

[ghost stip (do not use), 2016-10-20 19:31:28]

Description was changed from

==========
[Reland] Upgrade to new Android SDK.

https://codereview.chromium.org/2350013004/ was reverted due to breakage on the
perf waterfall. After https://codereview.chromium.org/2438563004/, this should
hopefully be resolved.

BUG=623989
==========

to

==========
[Reland] Upgrade to new Android SDK.

https://codereview.chromium.org/2350013004/ was reverted due to breakage on the
perf waterfall. After https://codereview.chromium.org/2438563004/, this should
hopefully be resolved.

BUG=623989
==========

[ghost stip (do not use), 2016-10-20 19:31:28]

stip@chromium.org changed reviewers:
+ jbudorick@chromium.org, xunjieli@chromium.org

[ghost stip (do not use), 2016-10-20 19:33:10]

xunjieli: ptal cronet OWNERS
jbudorick: still verifying this is correct, may need more lints

[xunjieli, 2016-10-20 19:38:28]

https://chromiumcodereview.appspot.com/2438133002/diff/1/components/cronet/to...
File components/cronet/tools/generate_javadoc.py (left):

https://chromiumcodereview.appspot.com/2438133002/diff/1/components/cronet/to...
components/cronet/tools/generate_javadoc.py:46: if " error: " in stdout or
"warning" in stdout or "javadoc: error " in stdout:
Talked about this change during a triage meeting. pauljensen@ said that ignore
all warnings is dangerous since that will result in broken @links in the
interim, and fixing those takes a lot of effort.

How about only ignore the compiler warnings? 

There are two lines. Maybe you can do some string matching of some sort to only
skip these two?

  [javadoc] warning:
/b/c/b/android_cronet/src/third_party/android_tools/sdk/platforms/android-24/android.jar(android/annotation/SuppressLint.class):
major version 52 is newer than 51, the highest major version supported by this
compiler.
  [javadoc]   It is recommended that the compiler be upgraded.

[ghost stip (do not use), 2016-10-20 20:18:28]

compiles cleanly locally, addressing xunjieli's comments next

[ghost stip (do not use), 2016-10-20 20:52:04]

this change should be good to go! ptal!

https://chromiumcodereview.appspot.com/2438133002/diff/1/components/cronet/to...
File components/cronet/tools/generate_javadoc.py (left):

https://chromiumcodereview.appspot.com/2438133002/diff/1/components/cronet/to...
components/cronet/tools/generate_javadoc.py:46: if " error: " in stdout or
"warning" in stdout or "javadoc: error " in stdout:
On 2016/10/20 19:38:28, xunjieli wrote:
> Talked about this change during a triage meeting. pauljensen@ said that ignore
> all warnings is dangerous since that will result in broken @links in the
> interim, and fixing those takes a lot of effort.
> 
> How about only ignore the compiler warnings? 
> 
> There are two lines. Maybe you can do some string matching of some sort to
only
> skip these two?
> 
>   [javadoc] warning:
>
/b/c/b/android_cronet/src/third_party/android_tools/sdk/platforms/android-24/android.jar(android/annotation/SuppressLint.class):
> major version 52 is newer than 51, the highest major version supported by this
> compiler.
>   [javadoc]   It is recommended that the compiler be upgraded.

Acknowledged.

https://chromiumcodereview.appspot.com/2438133002/diff/20001/components/crone...
File components/cronet/tools/generate_javadoc.py (right):

https://chromiumcodereview.appspot.com/2438133002/diff/20001/components/crone...
components/cronet/tools/generate_javadoc.py:46: for line in stdout.splitlines():
xunjieli: wdyt? I tested it and it definitely raises an error unless the only
warning is "the highest major version"

https://chromiumcodereview.appspot.com/2438133002/diff/20001/components/crone...
components/cronet/tools/generate_javadoc.py:51: if ("warning" in line and not
line.endswith('warnings') and
the endswith is because at the end it displays "664 warnings"

https://chromiumcodereview.appspot.com/2438133002/diff/20001/components/crone...
components/cronet/tools/generate_javadoc.py:53:
build_utils.DeleteDirectory(output_dir)
I felt the if statement was complicated enough that some code duplication was OK

[ghost stip (do not use), 2016-10-20 20:52:32]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 20:53:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2016-10-20 20:58:55]

LGTM thanks!

https://chromiumcodereview.appspot.com/2438133002/diff/20001/components/crone...
File components/cronet/tools/generate_javadoc.py (right):

https://chromiumcodereview.appspot.com/2438133002/diff/20001/components/crone...
components/cronet/tools/generate_javadoc.py:46: for line in stdout.splitlines():
On 2016/10/20 20:52:04, stip on NYC time wrote:
> xunjieli: wdyt? I tested it and it definitely raises an error unless the only
> warning is "the highest major version"

Seems good to me :)

https://chromiumcodereview.appspot.com/2438133002/diff/20001/components/crone...
components/cronet/tools/generate_javadoc.py:51: if ("warning" in line and not
line.endswith('warnings') and
On 2016/10/20 20:52:04, stip on NYC time wrote:
> the endswith is because at the end it displays "664 warnings"

Acknowledged.

https://chromiumcodereview.appspot.com/2438133002/diff/20001/components/crone...
components/cronet/tools/generate_javadoc.py:53:
build_utils.DeleteDirectory(output_dir)
On 2016/10/20 20:52:04, stip on NYC time wrote:
> I felt the if statement was complicated enough that some code duplication was
OK

Acknowledged.

[jbudorick, 2016-10-20 21:40:24]

lgtm

[commit-bot: I haz the power, 2016-10-20 22:04:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 22:04:56]

Dry run: This issue passed the CQ dry run.

[ghost stip (do not use), 2016-10-21 12:37:16]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2016-10-21 12:37:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 12:46:22]

Description was changed from

==========
[Reland] Upgrade to new Android SDK.

https://codereview.chromium.org/2350013004/ was reverted due to breakage on the
perf waterfall. After https://codereview.chromium.org/2438563004/, this should
hopefully be resolved.

BUG=623989
==========

to

==========
[Reland] Upgrade to new Android SDK.

https://codereview.chromium.org/2350013004/ was reverted due to breakage on the
perf waterfall. After https://codereview.chromium.org/2438563004/, this should
hopefully be resolved.

BUG=623989
==========

[commit-bot: I haz the power, 2016-10-21 12:46:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:29:00]

Description was changed from

==========
[Reland] Upgrade to new Android SDK.

https://codereview.chromium.org/2350013004/ was reverted due to breakage on the
perf waterfall. After https://codereview.chromium.org/2438563004/, this should
hopefully be resolved.

BUG=623989
==========

to

==========
[Reland] Upgrade to new Android SDK.

https://codereview.chromium.org/2350013004/ was reverted due to breakage on the
perf waterfall. After https://codereview.chromium.org/2438563004/, this should
hopefully be resolved.

BUG=623989

Committed: https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788
Cr-Commit-Position: refs/heads/master@{#426777}
==========

[commit-bot: I haz the power, 2016-10-21 13:29:01]

Patchset 2 (id:??) landed as
https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788
Cr-Commit-Position: refs/heads/master@{#426777}

[jbudorick, 2016-10-21 23:23:19]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2438913004/ by jbudorick@chromium.org.

The reason for reverting is: forward --list issues + gtest perf test adb
locations need to be updated..