Issue 2438113002: Fix handling of default formal parameters in DeclarationResolver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2438113002: Fix handling of default formal parameters in DeclarationResolver. (Closed)

Created:
4 years, 2 months ago by Paul Berry

Modified:
4 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix handling of default formal parameters in DeclarationResolver. When visiting a DefaultFormalParameter, we can't call super.visitDefaultFormalParameter, because that would cause the default value to be visited twice. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/74d8298777edeac7cc6a714156b255ec481324f8

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/analyzer/lib/src/generated/declaration_resolver.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/analyzer/test/src/context/context_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 2 months ago (2016-10-20 19:34:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
74d8298777edeac7cc6a714156b255ec481324f8 (presubmit successful).