components/metrics/public/cpp/call_stack_profile.typemap - Issue 2438073002: Use movable types for CallStackProfile(s) to remove copying of data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/public/cpp/call_stack_profile.typemap

Issue 2438073002: Use movable types for CallStackProfile(s) to remove copying of data. (Closed)

Patch Set: added some comments about std::move Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/public/cpp/call_stack_profile.typemap

diff --git a/components/metrics/public/cpp/call_stack_profile.typemap b/components/metrics/public/cpp/call_stack_profile.typemap

index a12ba83f47310523c7a24188cb0e1f5d9e719209..b189a585661c2df4ba5b71b9c0a0f1e978855365 100644

--- a/components/metrics/public/cpp/call_stack_profile.typemap

+++ b/components/metrics/public/cpp/call_stack_profile.typemap

@@ -17,7 +17,7 @@ deps = [

type_mappings = [

"metrics.mojom.CallStackModule=base::StackSamplingProfiler::Module",

"metrics.mojom.CallStackFrame=base::StackSamplingProfiler::Frame",

- "metrics.mojom.CallStackProfile=base::StackSamplingProfiler::CallStackProfile",

+ "metrics.mojom.CallStackProfile=base::StackSamplingProfiler::CallStackProfile[move_only]",

"metrics.mojom.CallStackProfileParams=metrics::CallStackProfileParams",

"metrics.mojom.Process=metrics::CallStackProfileParams::Process",

"metrics.mojom.SampleOrderingSpec=metrics::CallStackProfileParams::SampleOrderingSpec",