components/metrics/call_stack_profile_collector.h - Issue 2438073002: Use movable types for CallStackProfile(s) to remove copying of data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/call_stack_profile_collector.h

Issue 2438073002: Use movable types for CallStackProfile(s) to remove copying of data. (Closed)

Patch Set: added some comments about std::move Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/call_stack_profile_collector.h

diff --git a/components/metrics/call_stack_profile_collector.h b/components/metrics/call_stack_profile_collector.h

index f6a2ca1ce53925053a1e89ccbb4fb29cefa3486a..6eeb6a87b446a01423d3bba6c62e342b55d65412 100644

--- a/components/metrics/call_stack_profile_collector.h

+++ b/components/metrics/call_stack_profile_collector.h

@@ -25,7 +25,7 @@ class CallStackProfileCollector : public mojom::CallStackProfileCollector {

// mojom::CallStackProfileCollector:

void Collect(const CallStackProfileParams& params,

base::TimeTicks start_timestamp,

- const std::vector<CallStackProfile>& profiles) override;

+ std::vector<CallStackProfile> profiles) override;

private:

// Profile params are validated to come from this process. Profiles with a